From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f44.google.com (mail-oa1-f44.google.com [209.85.160.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A3982BEC5E for ; Thu, 21 May 2026 01:03:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779325411; cv=none; b=coWe241Fd4Jm94vuMrySa/8awtmJG4ZNcEKYaV9uKVNzFf2EDAW1NcCsVI9P72AIgbUKhigKNHjW7hxsi4I0eeKrcFr6DTZJ2JDqCP0ZUeIkV6qiYHzcFUDl0MLp25fiie1Tllf9XzWsHAzIPmUVa00oti1fKZRMMYZwHs2mjRs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779325411; c=relaxed/simple; bh=I1Bk0y7uh9jEUQlRg4tZ4CjR2YWjq1SMqrMc4cSuJ58=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=fcA5JUVM1KgZgf08xEAXGKeT5DsUw8qg6mAUIShLSD1Sq08lPA7QbXRi16TCacaDMSWbCaw2hjQq4yOgnS/lIw+sm4r+JcAFT+OWBLyaI4ICVcwSjNaAkY8wZVTFJX7rOkg1S4I/F8OZORgRWHkZZIcXjC2SXwEgcQYw3Wy9u40= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=c8ARVx4O; arc=none smtp.client-ip=209.85.160.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="c8ARVx4O" Received: by mail-oa1-f44.google.com with SMTP id 586e51a60fabf-40974bf7781so5149743fac.0 for ; Wed, 20 May 2026 18:03:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1779325408; x=1779930208; darn=lists.linux.dev; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=K5NSL+rhTt1O4xke8D9QIDMxAr5REVLMl3NEv7dtOAU=; b=c8ARVx4O3gDqV/065cDjFygjuk3CIcv2DomZTQoH8BlALm7N+aXuCA4CIZmUW/pXyC 2WOIer3cVYMwuqsanpSw1P7TqY/gBlIatsW7BWErqIISol5SLWSBlIjHRWR7poTZfRwe HXPQ74B+vueSC/sVrJGZLmZ++LlW5ij2MLwL/rD4GLc7yVraFZeqSUvxlGEUL6Zlp+/d gSLx9tCkyrfDKWwbuuxAZj2z9YJSZ/KAzDa9nU7easxiwl3ztjcHKI9Z89LXVwCPKXfT APQ0iW3B2c6ag3UAChudMau8+f7rhZB3dxqOsPFVluqaTaueK03fLiDFOv958wkuDG7K scAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779325408; x=1779930208; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=K5NSL+rhTt1O4xke8D9QIDMxAr5REVLMl3NEv7dtOAU=; b=ZBMX/ru9/cMMlVriOUTgIWd3EeeE3XzsIdaiv+1cgcbO9mUwpszxAEFu5e6u/1glF0 t/lqTXFSg8IO61zBYFYj8QRpag/X2ov/0IaM5RVT24IRk20wcQAbZXV6zjETROyl1YRc p6rLZThJs5bRDIhEo5ODe9FwhUs7RNfjeNBQUi9bwYGtNgDmkbi6GuhX8ChRWgPMdRlY yi1UP7b53NT4c/hgg19uuxXos3k1ktG7UltGqpenmIFPEI2ODJW6tkyJOCWFmT7Wgbz6 lq/6ykfTNzAvTxN1/DViOOy4x2nNjZ7nZ7WSlYD7/cewi2Bql+HRrzZ4UzxkXlz9HFY/ PewA== X-Forwarded-Encrypted: i=1; AFNElJ9xhPwYTaGBd0AaTcV8vBpU/3pUpJSyhR7pHBYI2ThK6JuiE9XbYTJ9bq/v+xiAWzkTAcIfEd6WYDSwcuY4gOMvSzIiWA==@lists.linux.dev X-Gm-Message-State: AOJu0YwUTtf5V5+LzoYEQzZN6vF1vQSnmeTlgQcWQ7LJWFWFl3CL0dMb VQf2wQ2Oe3+z1NU05qRTSMwaG39h43HL8yrUEvUMaAu9ol9qDCdaab2cUUXFEbHoqkg= X-Gm-Gg: Acq92OHqS39EPH1Nq2QfcDHyZVD6raU6Q/ovAcY9G4F6ZS/+3+V6+/wttMbDvF0jAwT L1K0TzjIoKuzHmvWv8rYKNkMTg372fBm/ElHoFgwFpZKDigVBf8/lszuvb3LLU8ZOvVdNLCKV1F Bx2qCPg8qbsTGOsML5OjziwT6mDa3o1nOHIP2aTcILseYGRgK7hwjTvoHAuW8YG/1fq3oElWtMk ebJNmQF1w9klo7a/DVg9O1CTd3i/kbd0swsy2xLoDJwYChgFj/4o99A7p1eINPsIYBcjZXhyrqA WB2a7KPGj7fTQZHKKyunWmjWh0kCki5rXihQ8nV1DFDKV9nV+XMSeILobM2N3SyNOF0Cbur9C5k lR6t9gOq1FWA6rHCnMr4P2gHmWNLshEY8OGhMZ0o2wBSb20F+Q/qVbHQxpgfHjGO3qLKDc+UTEo V72CwG5U4ZOry83E7Ejs17g8MZyXJuW31WNFC8WDVMTQfn8EUjFTpndo7c08f9zw/lNDXbKjsyL w== X-Received: by 2002:a05:6820:8309:b0:694:99de:9989 with SMTP id 006d021491bc7-69d6e37a176mr353611eaf.32.1779325408221; Wed, 20 May 2026 18:03:28 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:500:3658:e18d:1ce8:44cc? ([2600:8803:e7e4:500:3658:e18d:1ce8:44cc]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-43a956f6b2asm11003564fac.11.2026.05.20.18.03.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 May 2026 18:03:27 -0700 (PDT) Message-ID: Date: Wed, 20 May 2026 20:03:26 -0500 Precedence: bulk X-Mailing-List: linux-kernel-mentees@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 5/5] iio: light: tcs3472: move standalone return to default case To: Aldo Conte , Jonathan Cameron Cc: Andy Shevchenko , nuno.sa@analog.com, andy@kernel.org, shuah@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linux.dev References: <20260512223215.25596-1-aldocontelk@gmail.com> <20260512223215.25596-6-aldocontelk@gmail.com> <36ed59a7-8af7-4458-9e90-70ea251b389e@gmail.com> <20260515190517.70bb0ba5@jic23-huawei> <1c87362a-bba8-45b8-a836-153f468815c4@gmail.com> <20260516132555.64e27d62@jic23-huawei> <7f56ee25-11ad-4dcf-87bc-a353bed3f914@gmail.com> Content-Language: en-US From: David Lechner In-Reply-To: <7f56ee25-11ad-4dcf-87bc-a353bed3f914@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 5/20/26 12:12 PM, Aldo Conte wrote: > On 16/05/26 14:25, Jonathan Cameron wrote: >> On Sat, 16 May 2026 13:04:13 +0200 >> Aldo Conte wrote: >> >>> On 15/05/26 20:05, Jonathan Cameron wrote: >>>> On Wed, 13 May 2026 20:58:40 +0300 >>>> Andy Shevchenko wrote: >>> >>> ... >>> >>>> >>>> I would add for this that, to reduce churn it's fine to add the >>>> struct device *dev = ... bit and use it in new devm calls. Just do the >>>> remainder in the follow on commit. >>>>    >>>>> >>>>>   >>>>    >>> >>> Hi Jonathan, Andy and all! >>> >>> Thanks for your reviews! they’re teaching me so much! >>> If I understand correctly, I need to wait a week before submitting version v3 >>> such that other reviewers can comment right? >>> >>> I’d like to take this opportunity to suggest two alternative lists of what >>> version v3 might look like in terms of patch order: >>> >>> First option does not consider the "== NULL with !" patch and so: >>> 1. iio: tcs3472: power down chip on probe failure (NEW precursor, bug fix) >>> 2. iio: tcs3472: sort headers alphabetically (same) >>> 3. iio: tcs3472: convert several functions to use guard(mutex)() (modified) >>> 4. iio: tcs3472: use devm for resource management (slimmed down) >>> 5. iio: tcs3472: use locale struct device * for remaining cases (NEW) >>> 6. iio: tcs3472: implement wait time and sampling frequency (revised) >>> 7. iio: tcs3472: move standalone return to default case (same as v2) >>> >>> Second version will consider it: >>> 1. iio: tcs3472: power down chip on probe failure (NEW precursor, bug fix) >>> 2. iio: tcs3472: sort headers alphabetically (same as v2) >>> 3. iio: tcs3472: convert several functions to use guard(mutex)() (modified) >>> 4. iio: tcs3472: replace == NULL with ! (NEW, optional) >>> 5. iio: tcs3472: use devm for resource management (slimmed down) >>> 6. iio: tcs3472: use locale struct device * for remaining cases (NEW) >>> 7. iio: tcs3472: implement wait time and sampling frequency (revised) >>> 8. iio: tcs3472: move standalone return to default case (same as v2) >>> >>> >>> What do you think? >> Either is fine but swap the last two patches.  The wait time one is >> more complex than that trivial cleanup so might take more revisions. >> >> I frequently pick up the first part of series just to avoid people >> having to keep sending the same unchanged code to the list (that I've >> often forgotten about completely by the next version!) >> >> Jonathan >> >>> >>> >>> Thanks, >>> Aldo >> > > Hi Jonathan, > > I have two quick questions. > > First, Uwe's "[PATCH v2 0/7] iio: Rework i2c_device_id initialisation" also touches tcs3472.c. My series modifies the same file for unrelated reasons. Should I wait for Uwe's series to land and rebase on top, or is it fine to send now and let you handle the overlap? How does it work in  case? Just add a patch to your series that does the same change for that one file. Then it won't matter which one gets picked up first. > > Second, the first patch in my series fixes missing power-down on probe failure (goto err_powerdown). Do I need to add the “Fixes” tag? Sounds like it. > > Thanks for your time. > > Aldo Conte >