Re: [PATCH v3] lib/math: Add int_sqrt test suite

Luis Felipe Hernandez
2024-11-11T03:40:05Z

Hi David,

I wanted to follow up on this patch to check if any additional fixes
are needed. Additionally, I would like to address Andy Shevchenko's
<andriy.shevchenko@linux.intel.com> feedback in v2 regarding moving the
lib/math/test/* Kunit test Kconfig entries from lib/Kconfig.debug
to lib/tests/Kconfig?

> > > > --- a/lib/Kconfig.debug
> > > > +++ b/lib/Kconfig.debug
>
> > > Shouldn't the thing to be in lib/tests/Kconfig?
>
> > The Kconfig entries for lib/math are located in lib/Kconfig.debug as per
> > David Gow in https://lore.kernel.org/all/CABVgOS=-vh5TqHFCq_jo=ffq8v_nGgr6JsPnOZag3e6+19ysxQ@mail.gmail.com/
>
> He put it as "Somehow confusingly, ..." meaning to me as a signal that he will
> agree with me that moving that to lib/tests/Kconfig seems like a right move.

I am happy to make this change if it would be beneficial.

Best,

Felipe