Re: [PATCH v3] lib/math: Add int_sqrt test suite

Andrew Morton
2024-11-01T04:27:35Z

On Thu, 31 Oct 2024 20:25:56 -0600 Shuah Khan <skhan@linuxfoundation.org> wrote:

> >>> --- a/lib/math/Makefile
> >>> +++ b/lib/math/Makefile
> >>> @@ -9,3 +9,4 @@ obj-$(CONFIG_INT_POW_TEST) += tests/int_pow_kunit.o
> >>> obj-$(CONFIG_TEST_DIV64) += test_div64.o
> >>> obj-$(CONFIG_TEST_MULDIV64) += test_mul_u64_u64_div_u64.o
> >>> obj-$(CONFIG_RATIONAL_KUNIT_TEST) += rational-test.o
> >>> +obj-y += tests/
> >
> > What's this change about? It seems somewhat unrelated to adding a
> > single test. I mean, there's an unrelated test listed in
> > lib/math/tests/Makefile so what change does this patch have upon that
> > one?
> >
>
> I think this is a new test. I can take this for 6.13-rc1
>
> I thought the conflicts might persist in case you have any 6.13 material
> already in linux-next. Doesn't look like it if you could apply to 6.12-rc5
>
> Sorry for the confusion. I can take this for 6.13-rc1

x86_64 allmodconfig:

error: the following would cause module name conflict:
lib/math/tests/int_pow_kunit.ko
lib/math/tests/int_pow_kunit.ko