Re: [PATCH net] team: Move team device type change at the end of team_port_add

Jiri Pirko
2025-11-19T16:10:24Z

Tue, Nov 18, 2025 at 12:46:36PM +0100, pabeni@redhat.com wrote:
>On 11/12/25 1:34 AM, Nikola Z. Ivanov wrote:
>> @@ -1233,6 +1231,10 @@ static int team_port_add(struct team *team, struct net_device *port_dev,
>> }
>> }
>>
>> + err = team_dev_type_check_change(dev, port_dev);
>> + if (err)
>> + goto err_set_dev_type;
>
>Please don't add unneeded new labels, instead reuse the exiting
>`err_set_slave_promisc`.

Well, that is how error labels are done in team. "action" and
"err_action" is always paired. Why to break this consistent pattern?