Re: [PATCH v3 1/2] dt-bindings: iio: pressure: add honeywell,hsc030

Krzysztof Kozlowski
2023-11-27T08:06:59Z

On 26/11/2023 11:14, Petre Rodan wrote:
> Adds binding for digital Honeywell TruStability HSC and SSC series
> pressure and temperature sensors.
> Communication is one way. The sensor only requires 4 bytes worth of
> clock signals on both i2c and spi in order to push the data out.
> The i2c address is hardcoded and depends on the part number.
> There is no additional GPIO control.

> +
> + honeywell,transfer-function:
> + description: |
> + Transfer function which defines the range of valid values delivered by
> + the sensor.
> + 0 - A, 10% to 90% of 2^14
> + 1 - B, 5% to 95% of 2^14
> + 2 - C, 5% to 85% of 2^14
> + 3 - F, 4% to 94% of 2^14

You need enum here as well

> + $ref: /schemas/types.yaml#/definitions/uint32

> +
> + honeywell,pmin-pascal:
> + description: |
> + Minimum pressure value the sensor can measure in pascal.
> + To be specified only if honeywell,pressure-triplet is set to "NA".
> + $ref: /schemas/types.yaml#/definitions/int32
> +
> + honeywell,pmax-pascal:
> + description: |
> + Maximum pressure value the sensor can measure in pascal.
> + To be specified only if honeywell,pressure-triplet is set to "NA".
> + $ref: /schemas/types.yaml#/definitions/uint32

Sent a pull request:
https://github.com/devicetree-org/dt-schema/pull/118
Once it get merged, both $ref could be dropped.

Best regards,
Krzysztof