From: Mehdi Ben Hadj Khelifa <mehdi.benhadjkhelifa@gmail.com>
To: Viacheslav Dubeyko <Slava.Dubeyko@ibm.com>,
"brauner@kernel.org" <brauner@kernel.org>
Cc: "jack@suse.cz" <jack@suse.cz>,
"khalid@kernel.org" <khalid@kernel.org>,
"frank.li@vivo.com" <frank.li@vivo.com>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"slava@dubeyko.com" <slava@dubeyko.com>,
"david.hunter.linux@gmail.com" <david.hunter.linux@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-kernel-mentees@lists.linuxfoundation.org"
<linux-kernel-mentees@lists.linuxfoundation.org>,
"viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
"skhan@linuxfoundation.org" <skhan@linuxfoundation.org>,
"syzbot+ad45f827c88778ff7df6@syzkaller.appspotmail.com"
<syzbot+ad45f827c88778ff7df6@syzkaller.appspotmail.com>,
"glaubitz@physik.fu-berlin.de" <glaubitz@physik.fu-berlin.de>
Subject: Re: [PATCH v2] fs/hfs: fix s_fs_info leak on setup_bdev_super() failure
Date: Tue, 20 Jan 2026 14:52:06 +0100 [thread overview]
Message-ID: <cd4f1173-d5c3-42c1-8753-fb7b6c6ebad8@gmail.com> (raw)
In-Reply-To: <1bfac55095419b8c5d9dd73dbf9b8b94c74b264a.camel@ibm.com>
On 1/19/26 9:55 PM, Viacheslav Dubeyko wrote:
> On Mon, 2026-01-19 at 22:34 +0100, Mehdi Ben Hadj Khelifa wrote:
>> On 1/19/26 7:27 PM, Viacheslav Dubeyko wrote:
>>>
>
> <skipped>
>
>>>
>> I have ran xfstests on both my desktop and laptop on the for-next branch
>> for the repository that you have mentionned and I didn't have any crash
>> or issue. Here is the test results(identical for both desktop and laptop):
>> FSTYP -- hfsplus
>> PLATFORM -- Linux/x86_64 bhk 6.19.0-rc1-00008-ged8889ca21b6 #1 SMP
>> PREEMPT_DYNAMIC Mon Jan 19 20:53:58 CET 2026
>> MKFS_OPTIONS -- /dev/loop1
>> MOUNT_OPTIONS -- /dev/loop1 /mnt/scratch
>>
>> generic/001 2s ... 2s
>> generic/002 1s ... 1s
>> <skip>
>> Failed 51 of 772 tests
>>
>
> The 51 failed xfstests is expected situation. However, if you apply [1,2] on
> xfstests code base, then you could have around 31 failed xfeststs for HFS+.
>
I have applied both patches and got the expected results on my desktop
and laptop:
Failed 31 of 772 tests
I can confirm that indeed those patches fix 20 of the previously failed
tests.
> Thanks,
> Slava.
>
Best Regards,
Mehdi Ben hadj Khelifa
>> Many tests were skipped of course. If you want full output I can send
>> you that.But for now the issue seem to be resolved (for hfsplus at least
>> I'm not sure about hfs since I still can't test it on my system).
>> Thanks for your efforts slava.
>>
>>
>
> [1]
> https://lore.kernel.org/linux-fsdevel/20260118180519.xdddwoke2tey6ogt@dell-per750-06-vm-08.rhts.eng.pek2.redhat.com/
> [2]
> https://lore.kernel.org/linux-fsdevel/20251231224937.uu67l76cytcd36ns@dell-per750-06-vm-08.rhts.eng.pek2.redhat.com/
prev parent reply other threads:[~2026-01-20 12:52 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-19 7:38 [PATCH v2] fs/hfs: fix s_fs_info leak on setup_bdev_super() failure Mehdi Ben Hadj Khelifa
2025-11-19 14:14 ` Christian Brauner
2025-11-19 15:27 ` Mehdi Ben Hadj Khelifa
2025-11-19 19:58 ` Viacheslav Dubeyko
2025-11-19 22:21 ` Mehdi Ben Hadj Khelifa
2025-11-19 22:24 ` Mehdi Ben Hadj Khelifa
2025-11-21 19:44 ` Mehdi Ben Hadj Khelifa
2025-11-21 21:15 ` Viacheslav Dubeyko
2025-11-21 22:48 ` Mehdi Ben Hadj Khelifa
2025-11-21 22:04 ` Viacheslav Dubeyko
2025-11-21 23:16 ` Mehdi Ben Hadj Khelifa
2025-11-21 22:28 ` Viacheslav Dubeyko
2025-11-21 23:36 ` Mehdi Ben Hadj Khelifa
2025-11-21 23:01 ` Viacheslav Dubeyko
2025-11-25 22:14 ` Mehdi Ben Hadj Khelifa
2025-11-25 22:36 ` Viacheslav Dubeyko
2025-11-27 17:45 ` David Hunter
2025-11-29 13:06 ` Mehdi Ben Hadj Khelifa
2025-11-26 13:48 ` Christian Brauner
2025-11-26 16:06 ` Mehdi Ben Hadj Khelifa
2025-11-26 22:30 ` Viacheslav Dubeyko
2025-11-27 8:59 ` Christian Brauner
2025-11-27 20:19 ` Viacheslav Dubeyko
2025-11-29 12:48 ` Mehdi Ben Hadj Khelifa
2025-12-01 19:24 ` Viacheslav Dubeyko
2025-12-01 21:19 ` Mehdi Ben Hadj Khelifa
2025-12-01 20:37 ` Viacheslav Dubeyko
2025-12-01 21:57 ` Mehdi Ben Hadj Khelifa
2026-01-17 18:51 ` Mehdi Ben Hadj Khelifa
2026-01-19 17:48 ` Viacheslav Dubeyko
2026-01-19 19:03 ` Mehdi Ben Hadj Khelifa
2026-01-19 18:27 ` Viacheslav Dubeyko
2026-01-19 21:34 ` Mehdi Ben Hadj Khelifa
2026-01-19 20:55 ` Viacheslav Dubeyko
2026-01-20 13:52 ` Mehdi Ben Hadj Khelifa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd4f1173-d5c3-42c1-8753-fb7b6c6ebad8@gmail.com \
--to=mehdi.benhadjkhelifa@gmail.com \
--cc=Slava.Dubeyko@ibm.com \
--cc=brauner@kernel.org \
--cc=david.hunter.linux@gmail.com \
--cc=frank.li@vivo.com \
--cc=glaubitz@physik.fu-berlin.de \
--cc=jack@suse.cz \
--cc=khalid@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=slava@dubeyko.com \
--cc=syzbot+ad45f827c88778ff7df6@syzkaller.appspotmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox