public inbox for linux-kernel-mentees@lists.linux-foundation.org
 help / color / mirror / Atom feed
From: Nirbhay Sharma <nirbhay.lkd@gmail.com>
To: Jiri Olsa <olsajiri@gmail.com>
Cc: Kees Cook <kees@kernel.org>, Shuah Khan <shuah@kernel.org>,
	Andy Lutomirski <luto@amacapital.net>,
	Will Drewry <wad@chromium.org>,
	linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
	bpf@vger.kernel.org, khalid@kernel.org,
	david.hunter.linux@gmail.com,
	linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH] selftests/seccomp: fix pointer type mismatch in UPROBE test
Date: Sun, 26 Oct 2025 14:28:46 +0530	[thread overview]
Message-ID: <da05d1d1-c241-49af-bed8-7db5e9968396@gmail.com> (raw)
In-Reply-To: <aP0-k3vlEEWNUtF8@krava>



Hi Jiri,

Thank you for the review and for catching that inaccuracy!

On 10/26/25 2:48 AM, Jiri Olsa wrote:
> just probed_uprobe right?

Yes, you're absolutely correct. Only probed_uprobe has the
__attribute__((nocf_check)) attribute. I apologize for the confusion
in my original commit message. I'll fix this in v2.

> curious what compiler do you see that with?

I am seeing this error with Clang 19.1.2 on Fedora, which enables
-fcf-protection=full by default. As Sam confirmed, the error occurs
specifically when CFI protection is enabled via -fcf-protection. GCC
without this flag treats it as a warning or ignores the nocf_check
attribute entirely.

I'll send v2 with the corrected commit message.

Thanks again for the review!

Best regards,
Nirbhay


  parent reply	other threads:[~2025-10-26  8:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-25 18:49 [PATCH] selftests/seccomp: fix pointer type mismatch in UPROBE test Nirbhay Sharma
2025-10-25 21:18 ` Jiri Olsa
2025-10-26  0:25   ` Sam James
2025-10-26  8:58   ` Nirbhay Sharma [this message]
2025-10-26  9:12   ` [PATCH v2] " Nirbhay Sharma
2025-10-26 10:44     ` Sam James
2025-10-27  8:14     ` Jiri Olsa
2025-11-25 11:20     ` Nirbhay Sharma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=da05d1d1-c241-49af-bed8-7db5e9968396@gmail.com \
    --to=nirbhay.lkd@gmail.com \
    --cc=bpf@vger.kernel.org \
    --cc=david.hunter.linux@gmail.com \
    --cc=kees@kernel.org \
    --cc=khalid@kernel.org \
    --cc=linux-kernel-mentees@lists.linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=olsajiri@gmail.com \
    --cc=shuah@kernel.org \
    --cc=wad@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox