From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fhigh-b7-smtp.messagingengine.com (fhigh-b7-smtp.messagingengine.com [202.12.124.158]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD8531B0421 for ; Sat, 3 May 2025 18:52:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.12.124.158 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746298363; cv=none; b=e9fq1r7dCWjFnJcFua5oN0yVYVsm2WNZhikjeMUBqC0iILf09MbiqFAE7alpzZy7cThibiMaiwqv+h/dtptsZRFiHjbVAs/Dz/YRfbzvwLVN+xby8Kr9kjT/5XX41WMT93Zm6GcohHHwfBMzZxReSBi4ZoUkrp/QDckSqxn1I+I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746298363; c=relaxed/simple; bh=vq1V+e7vmAe9DRhMLKswG/UYbRE4x84iqvAItSwX2K4=; h=MIME-Version:Date:From:To:Cc:Message-Id:In-Reply-To:References: Subject:Content-Type; b=ANDtJYbhlAJVA1xmauBk9V3n+Q3ppcLrN6ABwUrfFNPkNf60cAiQCxnUODft4Y0F39REnGht4u71ZWwWKe5vJwJGTFNNiI0hgtVJ/xEs2fN1ta6T9+xhJ14Q0fAAVQQQX9btBU0h0F6Ev5qz44Y97uiOQw1rZdCDjxg1u7xqq24= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fastmail.com; spf=pass smtp.mailfrom=fastmail.com; dkim=pass (2048-bit key) header.d=fastmail.com header.i=@fastmail.com header.b=EJavWuzr; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=Aapabulk; arc=none smtp.client-ip=202.12.124.158 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fastmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fastmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fastmail.com header.i=@fastmail.com header.b="EJavWuzr"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="Aapabulk" Received: from phl-compute-06.internal (phl-compute-06.phl.internal [10.202.2.46]) by mailfhigh.stl.internal (Postfix) with ESMTP id 707CF2540115; Sat, 3 May 2025 14:52:38 -0400 (EDT) Received: from phl-imap-15 ([10.202.2.104]) by phl-compute-06.internal (MEProxy); Sat, 03 May 2025 14:52:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1746298358; x=1746384758; bh=L7whafli7ccrgxtjjLt2LWxTdI/uTPEKZB5Tk4Ozj10=; b= EJavWuzrdG2lF1+QcZXVqatf1Fn2BX8hkN8U4RKRlmsh1nXoBz4Qm7qzb42sWiq8 NPISbjGWj6Tdlqd5aLr7RVsZTs3Grhp8vI4b+P+o/2QQsy6WiC2vjux8OwCoHReJ K7JoJBMdaHsrNn8HZ5Nrk58Vzjfy4PhjMDjohQrHaZjkonENHWBYXELA8msr8tPS FrIE6uRz+lWgvR7+dae0TpVitPYDVbU0LJQttMOsxi+jWIOu6E3gwWy5K7DvRbNs l5snGA1AmJFitdy8kGP+VCin8YQizi1zRH8PPzvMqlBKrkpx2+BRwzgGXSYWNTAd LPrlBzA/0SwYVlU6+K7SeQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1746298358; x= 1746384758; bh=L7whafli7ccrgxtjjLt2LWxTdI/uTPEKZB5Tk4Ozj10=; b=A apabulkrmj/lvhEaoqF9mnr01F5XTnmTyCnDgOn+NzF9j6kPEt+gx+fcvKASXliL jDIKBDXOHtbnBihZuWnOsrWWtWGEWLuL2dSwje5fVcSCbz5w96e+c1SyvjU2/T1n KPqXsFlzOiK6B+Zolc9ABkRWhrj1oJn+tkpOqMeLUu5XOrJ3TRX0/JmwbndGG2nm QlCcg8KEbMM9E31uLp258zXzeG3eqX2HchUhoY45YQerwS7C4ZbWuaBKwlP1Cejg Njs7GUAsFSJcUGon7pUQ2dvAwrhqDDAAtbpDHMc8nLgMwiW6gcX+7+3YHJdEBPYx CgWaohr61jC0pxQSrG7PA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddvjeeiuddtucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggv pdfurfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpih gvnhhtshculddquddttddmnecujfgurhepofggfffhvfevkfgjfhfutgfgsehtjeertder tddtnecuhfhrohhmpeflrghmvghsuceosgholhgurdiiohhnvgdvfeejfeesfhgrshhtmh grihhlrdgtohhmqeenucggtffrrghtthgvrhhnpeeuhfdtheejiefghefhjedvheduuddv gefhveeiheduleevveehkeetiefgieeukeenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpegsohhlugdriihonhgvvdefjeefsehfrghsthhmrghi lhdrtghomhdpnhgspghrtghpthhtohepudefpdhmohguvgepshhmthhpohhuthdprhgtph htthhopegrlhgvgidrhhhunhhgsegrmhgurdgtohhmpdhrtghpthhtoheprghlvgigrghn uggvrhdruggvuhgthhgvrhesrghmugdrtghomhdprhgtphhtthhopegthhhrihhsthhirg hnrdhkohgvnhhighesrghmugdrtghomhdprhgtphhtthhopehhrghrrhihrdifvghnthhl rghnugesrghmugdrtghomhdprhgtphhtthhopehsuhhnphgvnhhgrdhlihesrghmugdrtg homhdprhgtphhtthhopehsihhmohhnrgesfhhffihllhdrtghhpdhrtghpthhtoheprghi rhhlihgvugesghhmrghilhdrtghomhdprhgtphhtthhopehsihhquhgvihhrrgesihhgrg hlihgrrdgtohhmpdhrtghpthhtohepshhkhhgrnheslhhinhhugihfohhunhgurghtihho nhdrohhrgh X-ME-Proxy: Feedback-ID: ibd7e4881:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id F1B4978006B; Sat, 3 May 2025 14:52:36 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface Precedence: bulk X-Mailing-List: linux-kernel-mentees@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ThreadId: T48d424c97f2c2475 Date: Sat, 03 May 2025 11:52:16 -0700 From: James To: "Alex Hung" , "Harry Wentland" , sunpeng.li@amd.com, "Rodrigo Siqueira" , "Alex Deucher" , =?UTF-8?Q?Christian_K=C3=B6nig?= , airlied@gmail.com, simona@ffwll.ch, "Shuah Khan" Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linux.dev Message-Id: In-Reply-To: <83eae1ce-ead2-47c9-a636-755a5207a6be@amd.com> References: <20250501055701.2667-1-bold.zone2373@fastmail.com> <83eae1ce-ead2-47c9-a636-755a5207a6be@amd.com> Subject: Re: [PATCH RESEND] drm/amd/display: adds kernel-doc comment for dc_stream_remove_writeback() Content-Type: text/plain Content-Transfer-Encoding: 7bit On Fri, May 2, 2025, at 3:25 PM, Alex Hung wrote: > Hi James, > > checkpatch reports the following warning and error > > WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit > description?) > #18: > Adds a kernel-doc for externally linked dc_stream_remove_writeback() > function. > > ERROR: trailing whitespace > #39: FILE: drivers/gpu/drm/amd/display/dc/core/dc_stream.c:561: > + * Return: returns true on success, false otherwise. $ > > total: 1 errors, 1 warnings, 14 lines checked > > > On 4/30/25 23:56, James Flowers wrote: >> Adds a kernel-doc for externally linked dc_stream_remove_writeback() function. >> >> Signed-off-by: James Flowers >> --- >> drivers/gpu/drm/amd/display/dc/core/dc_stream.c | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_stream.c b/drivers/gpu/drm/amd/display/dc/core/dc_stream.c >> index 0478dd856d8c..060ee6c3fc2e 100644 >> --- a/drivers/gpu/drm/amd/display/dc/core/dc_stream.c >> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_stream.c >> @@ -552,6 +552,14 @@ bool dc_stream_fc_disable_writeback(struct dc *dc, >> return true; >> } >> >> +/** >> + * dc_stream_remove_writeback() - Disables writeback and removes writeback info. >> + * @dc: Display core control structure. >> + * @stream: Display core stream state. >> + * @dwb_pipe_inst: Display writeback pipe. >> + * >> + * Return: returns true on success, false otherwise. >> + */ >> bool dc_stream_remove_writeback(struct dc *dc, >> struct dc_stream_state *stream, >> uint32_t dwb_pipe_inst) Thank you Alex, and sorry about that. I will correct those issues and submit a new version.