From: Hans de Goede <hansg@kernel.org>
To: Abdelrahman Fekry <abdelrahmanfekry375@gmail.com>,
hdegoede@redhat.com, andy@kernel.org
Cc: Andy Shevchenko <andriy.shevchenko@intel.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
mchehab@kernel.org, sakari.ailus@linux.intel.com,
gregkh@linuxfoundation.org, linux-kernel-mentees@lists.linux.dev,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
linux-staging@lists.linux.dev, skhan@linuxfoundation.com,
dan.carpenter@linaro.org
Subject: Re: [PATCH] staging: media: atomisp: Fix premature setting of HMM_BO_DEVICE_INITED flag
Date: Mon, 7 Jul 2025 15:55:42 +0200 [thread overview]
Message-ID: <e62996f0-d15a-4b4c-9be7-6d6bc96fdc8a@kernel.org> (raw)
In-Reply-To: <CAGn2d8M5+5ErZd0YF_hQ75j5FWEFC60qCPX6U7G5j2HgDmz1PA@mail.gmail.com>
Hi Abdelrhaman,
On 7-Jul-25 15:26, Abdelrahman Fekry wrote:
> Hi Hans, Andy
>
> On Sun, Jul 6, 2025 at 9:25 PM Hans de Goede <hansg@kernel.org> wrote:
>>
>> Hi, Abdelrahman
>>
>> On 1-Jul-25 5:45 PM, Abdelrahman Fekry wrote:
>>> Hi Hans,
>>>
>>> On Tue, Jul 1, 2025 at 4:54 PM Hans de Goede <hansg@kernel.org> wrote:
>
>> * And maybe you'll find more possible cleanups while working on this
>
> I was working on some cleanups and i found something that i really
> don't understand.
> how is the error checking of hmm_alloc is handled , some functions are
> checking the
> returning value of it using mmgr_NULL and other use mmgr_EXCEPTION
> while in fact, when __hm_alloc fails it doesn't return either
> mmgr_EXCEPTION or mmgr_NULL in
> most cases.
Sounds like you've found another issue to fix :)
Regards,
Hans
next prev parent reply other threads:[~2025-07-07 13:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-28 5:25 [PATCH] staging: media: atomisp: Fix premature setting of HMM_BO_DEVICE_INITED flag Abdelrahman Fekry
2025-06-28 19:52 ` Andy Shevchenko
2025-06-29 9:51 ` Abdelrahman Fekry
2025-07-01 11:58 ` Abdelrahman Fekry
2025-07-01 12:45 ` Andy Shevchenko
2025-07-01 13:54 ` Hans de Goede
2025-07-01 15:45 ` Abdelrahman Fekry
2025-07-06 18:25 ` Hans de Goede
2025-07-07 10:57 ` Abdelrahman Fekry
2025-07-07 13:26 ` Abdelrahman Fekry
2025-07-07 13:55 ` Hans de Goede [this message]
2025-07-01 15:33 ` Abdelrahman Fekry
2025-07-01 18:00 ` Andy Shevchenko
2025-07-06 16:22 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e62996f0-d15a-4b4c-9be7-6d6bc96fdc8a@kernel.org \
--to=hansg@kernel.org \
--cc=abdelrahmanfekry375@gmail.com \
--cc=andriy.shevchenko@intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=andy@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=skhan@linuxfoundation.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox