From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f41.google.com (mail-oa1-f41.google.com [209.85.160.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B6EB43F09F for ; Mon, 10 Aug 2026 19:28:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786390115; cv=none; b=ZJ3sbs31YE5O37j+23oUxj8C/w8F4o5plCNLB3/4IIsdp0MZehP+KxBLLayHA3wBaKJ7IVOhG+IgEipD0OcxpWbGTPWzknU/ncTVL6fFCb9JQHJ5Qwqr1dUCYgb8lydeCiwRhQWPK2WN32H0766M/NR2Qpkwk6ugfPqxZXPz1bw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786390115; c=relaxed/simple; bh=+sEsScIM2qAs6sSevujTtRTZbuA1fPGvSKnZmuUlN0M=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qJ0Vs46yIwgiTzJfZTYMQnxPo+Fh+Dql/JzcdxnYchYAj8PBq8rtx7Wq8YbxAOG9vwTMbiLBNji9Y5k0hbUxA5ytRsmQMybXGGIdSRiDwBN3GqshsI8ctvNrZS8MtqoGNrs/gbzu9voulx+eC7BvgPg1Cgv4VLvIyVexFdgZzQI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=MWe33Yly; arc=none smtp.client-ip=209.85.160.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="MWe33Yly" Received: by mail-oa1-f41.google.com with SMTP id 586e51a60fabf-43bf9548df4so1383308fac.0 for ; Mon, 10 Aug 2026 12:28:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1786390108; x=1786994908; darn=lists.linux.dev; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=NgO72jJ70tMCTC4c4xhvVwaNiqswCBephsns35OjoNk=; b=MWe33YlyvAqtRwSyXkKn4AZxepg3xoay9R0tzxIdMFTcCLmDodVGV7NlkpUkbLHgT8 vOchqSp/qwnWmi5WK4SioVUouNalmdefdRN4L3pFQUxamnKs9Rtrs7mFVr40yxKu84Sh rII99DV/bRQxaI7cI+2F4G8DVSXvCJYRd7CEDs6iO5H+9DXIlQjjhzUy5KVLo3xAPJ2I W2tNX88sGgzSQdaSIZBz8nCRuJqdpn44Oc/MpOtZeOUXR6oJMYGZr7QTnNbhSbyjWHNq o8djtajTxLH2EmtZnv2181u85PAZVIy+guRYYhyipBCSnCMGEx7L+EVTLTxu54dtUSw2 jYQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786390108; x=1786994908; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=NgO72jJ70tMCTC4c4xhvVwaNiqswCBephsns35OjoNk=; b=kawOvJyb51Iogau8rDkFDNkUik9gg29GRCMymKhfB3DUwjlNylX2olqlE2rTFD6yMi Sk8VVgFtABPGHy0cVg+07/zTdCWjmK4RAXA6gx1KBuB9+UaXMvHyWF5GzT4QRdM8y+2z AYLhEEKkKCiVOaQ7kmEsQ2IEynSi5dJT+uNf3UekJhnfPcdcGeJ1zeXjPDEoCM8FUvjW dhsqHAvyecwgNiVpJ66631QnuLrqevrSklBRS1n6Kmq9w2jCZpCMmkHj5MS1+ltcdPh1 iHACYD6qYRJ1L/mRtP0KuKDVkjXluT95uCSEtK6Ss2+DJ+Ui7wqntsnGxn3UEcBJwnmJ DGMw== X-Forwarded-Encrypted: i=1; AHgh+RrLZC/atqDf0Dd9naMtttTHjJVgYZYsyS7DBWd6nXhNF3lJvoNxkFKHSagGPP3WyB4COpyqRR0OW7C615WDrDOkQi2eiw==@lists.linux.dev X-Gm-Message-State: AOJu0YwQEYTZdYezYUSVcEdaiMF583Ztl9koCmVqGV/eLJc9afhf5vyp MLCeJEgDq71hzhoWatqLpoY05STfDKcnZ56hjs+j1OdM6faeqUNCfSAqk3C2kzrKgvO/0Jtw4jo rfmLABBI= X-Gm-Gg: AR+sD1195Yf8Ws4bgJmPm2hVRPxlVOO39YGEpY5ff5xKXfAacyud7PlOmcrnUi9LrDG XrqvzZBJi/EH9/TGPv5o6jf0edyDlTRgAhrNl9U4zHfF2FEZSzqClpyW9/V1grkxNeC0e4lkCpR fyoMBbSnosqJNZxILy0djmzLkXFcUJlQttxac62+8rYrak26NR3mXApd+1bqD2oYTrA5e855lmN 9u/PFAG+yjVOt1Wcs+7m6Y8/clfOL3TTfvfArWGTxWmEfVielmBnl0LFdlSiHRTUh0Ewb5gpg/W 7aRffLCFq7zsPhl77XZiJ3X7RHolNTFw4MwbL8cnq6XBjSJLDM9VXpLJM9h2wY6gvEg8YRjAEOP 40x28ZOkMSW3Nc/T++qn8MjNFAJqdt6DJJZCJ95huhaRyFB8XWXRvevPfHGzikhZ4OPn4xufC1H Ub75m6teWBCgAxixTYzY9uQ1uivlA7xvpfFU/3QywC+KPPzd3lcZJ437C9WOEuAXIfx9y4dr5Mi A1FFACXiw8R20/wy8ZJeXDxESqi/edHb3buZvM= X-Received: by 2002:a05:6870:3d96:b0:441:f3f6:622b with SMTP id 586e51a60fabf-45e0552f4d0mr2384263fac.5.1786390108284; Mon, 10 Aug 2026 12:28:28 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:500:e05b:7923:cf50:e4cf? ([2600:8803:e7e4:500:e05b:7923:cf50:e4cf]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-459f1a76701sm8915038fac.5.2026.08.10.12.28.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Aug 2026 12:28:27 -0700 (PDT) Message-ID: Date: Mon, 10 Aug 2026 14:28:26 -0500 Precedence: bulk X-Mailing-List: linux-kernel-mentees@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] iio: humidity: am2315: add am2320 to i2c_device_id table To: =?UTF-8?Q?Nicol=C3=A1s_Antinori?= , Jonathan Cameron Cc: Andy Shevchenko , Brigham Campbell , Jori Koolstra , Marcelo Schmitt , =?UTF-8?Q?Nuno_S=C3=A1?= , Shuah Khan , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linux.dev References: <20260810183337.451812-1-nico.antinori.7@gmail.com> Content-Language: en-US From: David Lechner In-Reply-To: <20260810183337.451812-1-nico.antinori.7@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 8/10/26 1:32 PM, Nicolás Antinori wrote: > The AM2320 is fully compatible with the AM2315 sensor in terms of I2C > communication protocol and measurement conversions. > > Add the "am2320" entry to the i2c_device_id table. Interesting. No devicetree bindings for this one? What kind of system is it on? > > Signed-off-by: Nicolás Antinori > --- > v2: > - Adapted KConfig text using the suggestions from v1 by Nuno Sá and Andy > Shevchenko > > v1: https://lore.kernel.org/all/20260805183733.1000550-1-nico.antinori.7@gmail.com/T/#u > > drivers/iio/humidity/Kconfig | 8 +++++--- > drivers/iio/humidity/am2315.c | 3 ++- > 2 files changed, 7 insertions(+), 4 deletions(-) > > diff --git a/drivers/iio/humidity/Kconfig b/drivers/iio/humidity/Kconfig > index 54f11f000b6f..10598a0b15bc 100644 > --- a/drivers/iio/humidity/Kconfig > +++ b/drivers/iio/humidity/Kconfig > @@ -5,13 +5,15 @@ > menu "Humidity sensors" > > config AM2315 > - tristate "Aosong AM2315 relative humidity and temperature sensor" > + tristate "Aosong AM2315 and similar relative humidity and temperature sensor" > depends on I2C > select IIO_BUFFER > select IIO_TRIGGERED_BUFFER > help > - If you say yes here you get support for the Aosong AM2315 > - relative humidity and ambient temperature sensor. > + If you say yes here you get support for the Aosong relative > + humidity and ambient temperature sensors: > + - AM2315 > + - AM2320 > > This driver can also be built as a module. If so, the module will > be called am2315. > diff --git a/drivers/iio/humidity/am2315.c b/drivers/iio/humidity/am2315.c > index f29baa251f9f..5bce5eec45cc 100644 > --- a/drivers/iio/humidity/am2315.c > +++ b/drivers/iio/humidity/am2315.c > @@ -1,6 +1,6 @@ > // SPDX-License-Identifier: GPL-2.0-only > /* > - * Aosong AM2315 relative humidity and temperature > + * Aosong AM2315 and similar relative humidity and temperature > * > * Copyright (c) 2016, Intel Corporation. > * > @@ -251,6 +251,7 @@ static int am2315_probe(struct i2c_client *client) > > static const struct i2c_device_id am2315_i2c_id[] = { > { .name = "am2315" }, > + { .name = "am2320" }, > { } > }; > MODULE_DEVICE_TABLE(i2c, am2315_i2c_id); > -- > 2.47.3 > Currently, the driver sets `indio_dev->name = AM2315_DRIVER_NAME;` Usually, when there is more than one chip supported in a driver, we want this to be the the name of the actual chip. (And we usually try to avoid DRIVER_NAME macros so removing that would be a welcome change.)