Re: [PATCH] usb: storage: ene_ub6250: Fix right shift warnings

Alan Stern
2024-07-29T18:34:53Z

On Mon, Jul 29, 2024 at 11:53:48PM +0530, Abhishek Tamboli wrote:
> Change bl_len from u16 to u32 to accommodate the necessary bit shifts.
>
> Fix the following smatch warnings:
>
> drivers/usb/storage/ene_ub6250.c:1509 ms_scsi_read_capacity() warn: right shifting more than type allows 16 vs 24
> drivers/usb/storage/ene_ub6250.c:1510 ms_scsi_read_capacity() warn: right shifting more than type allows 16 vs 16
>
> Signed-off-by: Abhishek Tamboli <abhishektamboli9@gmail.com>
> ---
> drivers/usb/storage/ene_ub6250.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/storage/ene_ub6250.c b/drivers/usb/storage/ene_ub6250.c
> index 97c66c0d91f4..ab6718dc874f 100644
> --- a/drivers/usb/storage/ene_ub6250.c
> +++ b/drivers/usb/storage/ene_ub6250.c
> @@ -1484,7 +1484,7 @@ static int ms_scsi_mode_sense(struct us_data *us, struct scsi_cmnd *srb)
> static int ms_scsi_read_capacity(struct us_data *us, struct scsi_cmnd *srb)
> {
> u32 bl_num;
> - u16 bl_len;
> + u32 bl_len;
> unsigned int offset = 0;
> unsigned char buf[8];
> struct scatterlist *sg = NULL;

Acked-by: Alan Stern <stern@rowland.harvard.edu>