From: Shuah Khan <skhan@linuxfoundation.org>
To: Rahul Kumar <rk0006818@gmail.com>,
liviu.dudau@arm.com, maarten.lankhorst@linux.intel.com,
mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com,
simona@ffwll.ch
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linux.dev,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v3] drm/komeda: Convert logging in komeda_crtc.c to drm_* with drm_device parameter
Date: Tue, 7 Oct 2025 17:16:27 -0600 [thread overview]
Message-ID: <f774da25-ab98-4731-b78d-394d8e3a4c3a@linuxfoundation.org> (raw)
In-Reply-To: <CAKY2RybMM5jcOzO_mknsdH+m9-T+Qe3yMhRrdpV_VE4paUrAKw@mail.gmail.com>
On 10/3/25 11:51, Rahul Kumar wrote:
> Hi Liviu,
>
> Just following up to ask if anything more is needed from my side for
> this patch, or if you plan to pick it up in this merge window.
>
> Thanks,
> Rahul
>
Rahul, no top posting. Please give people time to respond before
sending a second email asking for feedback. I see two messages
back to back from you - perhaps an error during send.
> On Fri, Sep 26, 2025 at 3:00 PM Rahul Kumar <rk0006818@gmail.com> wrote:
>>
>> Replace all dev_err(), dev_warn(), dev_info() and DRM_ERROR/WARN/INFO()
>> calls in drivers/gpu/drm/arm/display/komeda/komeda_crtc.c with the
>> corresponding drm_err(), drm_warn(), and drm_info() helpers.
>>
>> The new drm_*() logging functions take a struct drm_device * as the
>> first argument. This allows the DRM core to prefix log messages with
>> the specific DRM device name and instance, which is essential for
>> distinguishing logs when multiple GPUs or display controllers are present.
>>
>> This change aligns komeda with the DRM TODO item: "Convert logging to
>> drm_* functions with drm_device parameter".
>>
>> Signed-off-by: Rahul Kumar <rk0006818@gmail.com>
>> Reviewed-by: Liviu Dudau <liviu.dudau@arm.com>
>> ---
>> Changes since v2:
>> - Added Reviewed-by tag from Liviu Dudau
>>
thanks,
-- Shuah
next prev parent reply other threads:[~2025-10-07 23:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-26 9:30 [PATCH v3] drm/komeda: Convert logging in komeda_crtc.c to drm_* with drm_device parameter Rahul Kumar
2025-10-03 17:51 ` Rahul Kumar
2025-10-07 23:16 ` Shuah Khan [this message]
2025-10-16 15:38 ` Liviu Dudau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f774da25-ab98-4731-b78d-394d8e3a4c3a@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=liviu.dudau@arm.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=rk0006818@gmail.com \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox