From: Aurabindo Pillai <aurabindo.pillai@amd.com>
To: Abhishek Tamboli <abhishektamboli9@gmail.com>,
airlied@gmail.com, daniel@ffwll.ch, harry.wentland@amd.com,
sunpeng.li@amd.com, Rodrigo.Siqueira@amd.com,
alexander.deucher@amd.com, christian.koenig@amd.com,
Xinhui.Pan@amd.com
Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, skhan@linuxfoundation.org,
rbmarliere@gmail.com,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH] drm: Fix documentation warning for read_mpcc_state in mpc.h
Date: Mon, 15 Jul 2024 17:46:38 -0400 [thread overview]
Message-ID: <fb2b106e-aa51-4108-9d61-ba71935fba00@amd.com> (raw)
In-Reply-To: <20240712174510.70467-1-abhishektamboli9@gmail.com>
On 7/12/24 1:45 PM, Abhishek Tamboli wrote:
> Add detail description for the read_mpcc_state function in the
> mpc_funcs struct to resolve the documentation warning.
>
> A kernel-doc warning was addressed:
> ./drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:547: warning:
> Function parameter or struct member 'read_mpcc_state' not
> described in 'mpc_funcs'.
>
> Signed-off-by: Abhishek Tamboli <abhishektamboli9@gmail.com>
> ---
> drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h b/drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h
> index 34a398f23fc6..9e65ecf1d3b0 100644
> --- a/drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h
> +++ b/drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h
> @@ -282,6 +282,22 @@ struct mpcc_state {
> * struct mpc_funcs - funcs
> */
> struct mpc_funcs {
> + /**
> + * @read_mpcc_state:
> + *
> + * Reads the state of a given MPCC instance.
> + *
> + * Parameters:
> + *
> + * - [in/out] mpc - MPC context.
> + * - [in] mpcc_inst - MPCC Instance whose state is to be read.
> + * - [out] mpcc_state - MPCC state structure where the state
> + * of the MPCC instance will be stored.
> + *
> + * Return:
> + *
> + * void
> + */
> void (*read_mpcc_state)(
> struct mpc *mpc,
> int mpcc_inst,
Looks like fix for this has been already merged via a195f08636f9d7
drm/amd/display: fix documentation warnings for mpc.h
--
Thanks & Regards,
Aurabindo Pillai
next prev parent reply other threads:[~2024-07-15 21:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-12 17:45 [PATCH] drm: Fix documentation warning for read_mpcc_state in mpc.h Abhishek Tamboli
2024-07-15 21:46 ` Aurabindo Pillai [this message]
2024-07-17 16:30 ` Abhishek Tamboli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb2b106e-aa51-4108-9d61-ba71935fba00@amd.com \
--to=aurabindo.pillai@amd.com \
--cc=Rodrigo.Siqueira@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=abhishektamboli9@gmail.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=harry.wentland@amd.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rbmarliere@gmail.com \
--cc=skhan@linuxfoundation.org \
--cc=sunpeng.li@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox