From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6470229DB64 for ; Thu, 9 Jul 2026 07:17:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783581454; cv=none; b=lMoEWWbu2NZ/YLiK9FHTYpeFpJQor1TCuiFvTMzF/lbaYBWAA93sFb8KmCt85j/UtmTeoXpcWK7ow9ZTmDYVvB3+a1Jz7LLXQ0jn5ayL9Bd0MDmvaCO7DYwEj8OZOk2gXnSYQxiLCGhGDSPCfwQ6NuB426YhyPl4ro3wdY0e5UY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783581454; c=relaxed/simple; bh=SaEEq4g+WuiSDg3BM/+yLXEJ1HczZ++3yoaX7mnITnc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=AXBf5lQXt/4GtE55RP1ANJhiUW6uNx9iIVT743RTmR7fXcyHqIZ+EleLccCp6bRO00BRDacwR1hJiKIQ+a124gUA9PhT/IMzGkz+A/TM8Qjp0t1r/PTIY2OdcnHwNiKMjKzXkFCKwMakR3EYG0opQmHS7MP7r5KE4imuiHRpdA0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=PjZzkzyy; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=wbii7Sd0; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=0JzL3oR5; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=BC/tholT; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="PjZzkzyy"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="wbii7Sd0"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="0JzL3oR5"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="BC/tholT" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id CD84D75E3E; Thu, 9 Jul 2026 07:17:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1783581451; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=wJWchXKiIe+/JTnT/jyFuWq42F8Rvy/XNisdngkOA44=; b=PjZzkzyyr0mCbhartpMyxnskjHFxTbOPh/2y/OWR9IEa7iCxoE968JlD4U/36mHeI2OSGv +xmfs+LpbVALARMgB2QxUj0F/sBHW7hCJ1aB9HN3j5vgPvie42gtqQgwdpowF4PiqirsrN oXDgchfOiw8zl2wKq4WJBmTkwqKUJMQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1783581451; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=wJWchXKiIe+/JTnT/jyFuWq42F8Rvy/XNisdngkOA44=; b=wbii7Sd05QK5lWmYk7m0HO+fNWizxsVTk3Or9dW3EdWEUrrUBCXmR7zd9MgYR3iFFr1P80 ghSwquw85pACUAAg== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1783581449; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=wJWchXKiIe+/JTnT/jyFuWq42F8Rvy/XNisdngkOA44=; b=0JzL3oR5uLLiCBc4AXOPoDZLmb7bta4GBJXAe/uMRWDnn1z96PAyTkNatvC3NjITDSMMFG UmzdANCGEeq3o0XPfANU5bFK3Blxjav5eh5rYZZ+FJNInp8ff9j9AfbzQPm7Ir30fzozHG N0wfNJnaZpJajaDa/XQAqJ7Fc8ZVu5w= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1783581449; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=wJWchXKiIe+/JTnT/jyFuWq42F8Rvy/XNisdngkOA44=; b=BC/tholTpUp/7iq3peiGlmNB6qSssS66sgizUs9lMxDWd0qCgLH9NIJpVo2hT/CaJ5gkti 5VVEv0SUBifzc6DA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 89711779AA; Thu, 9 Jul 2026 07:17:29 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id h/5SIAlLT2o7PgAAD6G6ig (envelope-from ); Thu, 09 Jul 2026 07:17:29 +0000 Message-ID: Date: Thu, 9 Jul 2026 09:17:29 +0200 Precedence: bulk X-Mailing-List: linux-kernel-mentees@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/amdgpu: Inline drm_simple_encoder_init() To: =?UTF-8?Q?Nicol=C3=A1s_Antinori?= , =?UTF-8?Q?Christian_K=C3=B6nig?= Cc: Alex Deucher , Brigham Campbell , David Airlie , Shuah Khan , Simona Vetter , linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linux.dev, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org References: <20260708222035.7324-1-nico.antinori.7@gmail.com> Content-Language: en-US From: Thomas Zimmermann Autocrypt: addr=tzimmermann@suse.de; keydata= xsBNBFs50uABCADEHPidWt974CaxBVbrIBwqcq/WURinJ3+2WlIrKWspiP83vfZKaXhFYsdg XH47fDVbPPj+d6tQrw5lPQCyqjwrCPYnq3WlIBnGPJ4/jreTL6V+qfKRDlGLWFjZcsrPJGE0 BeB5BbqP5erN1qylK9i3gPoQjXGhpBpQYwRrEyQyjuvk+Ev0K1Jc5tVDeJAuau3TGNgah4Yc hdHm3bkPjz9EErV85RwvImQ1dptvx6s7xzwXTgGAsaYZsL8WCwDaTuqFa1d1jjlaxg6+tZsB 9GluwvIhSezPgnEmimZDkGnZRRSFiGP8yjqTjjWuf0bSj5rUnTGiyLyRZRNGcXmu6hjlABEB AAHNJ1Rob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmRlPsLAjgQTAQgAOAIb AwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftODH AAoJEGgNwR1TC3ojx1wH/0hKGWugiqDgLNXLRD/4TfHBEKmxIrmfu9Z5t7vwUKfwhFL6hqvo lXPJJKQpQ2z8+X2vZm/slsLn7J1yjrOsoJhKABDi+3QWWSGkaGwRJAdPVVyJMfJRNNNIKwVb U6B1BkX2XDKDGffF4TxlOpSQzdtNI/9gleOoUA8+jy8knnDYzjBNOZqLG2FuTdicBXblz0Mf vg41gd9kCwYXDnD91rJU8tzylXv03E75NCaTxTM+FBXPmsAVYQ4GYhhgFt8S2UWMoaaABLDe 7l5FdnLdDEcbmd8uLU2CaG4W2cLrUaI4jz2XbkcPQkqTQ3EB67hYkjiEE6Zy3ggOitiQGcqp j//OwE0EWznS4AEIAMYmP4M/V+T5RY5at/g7rUdNsLhWv1APYrh9RQefODYHrNRHUE9eosYb T6XMryR9hT8XlGOYRwKWwiQBoWSDiTMo/Xi29jUnn4BXfI2px2DTXwc22LKtLAgTRjP+qbU6 3Y0xnQN29UGDbYgyyK51DW3H0If2a3JNsheAAK+Xc9baj0LGIc8T9uiEWHBnCH+RdhgATnWW GKdDegUR5BkDfDg5O/FISymJBHx2Dyoklv5g4BzkgqTqwmaYzsl8UxZKvbaxq0zbehDda8lv hFXodNFMAgTLJlLuDYOGLK2AwbrS3Sp0AEbkpdJBb44qVlGm5bApZouHeJ/+n+7r12+lqdsA EQEAAcLAdgQYAQgAIAIbDBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftOH6AAoJEGgNwR1T C3ojVSkIALpAPkIJPQoURPb1VWjh34l0HlglmYHvZszJWTXYwavHR8+k6Baa6H7ufXNQtThR yIxJrQLW6rV5lm7TjhffEhxVCn37+cg0zZ3j7zIsSS0rx/aMwi6VhFJA5hfn3T0TtrijKP4A SAQO9xD1Zk9/61JWk8OysuIh7MXkl0fxbRKWE93XeQBhIJHQfnc+YBLprdnxR446Sh8Wn/2D Ya8cavuWf2zrB6cZurs048xe0UbSW5AOSo4V9M0jzYI4nZqTmPxYyXbm30Kvmz0rYVRaitYJ 4kyYYMhuULvrJDMjZRvaNe52tkKAvMevcGdt38H4KSVXAylqyQOW5zvPc4/sq9c= In-Reply-To: <20260708222035.7324-1-nico.antinori.7@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Flag: NO X-Spam-Score: -2.80 X-Spamd-Result: default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[100.00%]; SUSPICIOUS_RECIPS(1.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_TLS_ALL(0.00)[]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; TAGGED_RCPT(0.00)[]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_TO(0.00)[gmail.com,amd.com]; MID_RHS_MATCH_FROM(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; FREEMAIL_CC(0.00)[amd.com,brighamcampbell.com,gmail.com,linuxfoundation.org,ffwll.ch,vger.kernel.org,lists.linux.dev,lists.freedesktop.org]; RCPT_COUNT_SEVEN(0.00)[11]; FROM_EQ_ENVFROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email,suse.de:mid,imap1.dmz-prg2.suse.org:helo,suse.com:url] X-Spam-Level: Am 09.07.26 um 00:20 schrieb Nicolás Antinori: > Simple KMS helpers are deprecated because they introduce an unnecessary > intermediate layer between atomic modesetting and the DRM driver. > > Inline the functionality of drm_simple_encoder_init() to remove > dependencies on these deprecated helpers. > > Signed-off-by: Nicolás Antinori Reviewed-by: Thomas Zimmermann > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c > index 170adaf7e76a..d5b0692fe860 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c > @@ -2,7 +2,7 @@ > > #include > #include > -#include > +#include > #include > #include > #include > @@ -316,6 +316,10 @@ static struct drm_plane *amdgpu_vkms_plane_init(struct drm_device *dev, > return plane; > } > > +static const struct drm_encoder_funcs drm_encoder_funcs_cleanup = { > + .destroy = drm_encoder_cleanup, > +}; > + > static int amdgpu_vkms_output_init(struct drm_device *dev, struct > amdgpu_vkms_output *output, int index) > { > @@ -342,7 +346,9 @@ static int amdgpu_vkms_output_init(struct drm_device *dev, struct > > drm_connector_helper_add(connector, &amdgpu_vkms_conn_helper_funcs); > > - ret = drm_simple_encoder_init(dev, encoder, DRM_MODE_ENCODER_VIRTUAL); > + ret = drm_encoder_init(dev, encoder, > + &drm_encoder_funcs_cleanup, > + DRM_MODE_ENCODER_VIRTUAL, NULL); > if (ret) { > DRM_ERROR("Failed to init encoder\n"); > goto err_encoder; > -- > 2.47.3 > -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, (HRB 36809, AG Nürnberg)