* [PATCH] mtd: sm_ftl: replace strncpy with memcpy
@ 2025-09-03 12:17 Rahul Kumar
2025-09-03 14:28 ` Pratyush Yadav
0 siblings, 1 reply; 2+ messages in thread
From: Rahul Kumar @ 2025-09-03 12:17 UTC (permalink / raw)
To: miquel.raynal, richard, vigneshr
Cc: linux-mtd, linux-kernel, linux-kernel-mentees, skhan, rk0006818
Replace strncpy with memcpy in sm_attr_show and explicitly add a NUL
terminator after the copy. This aligns with current kernel best practices
as strncpy is deprecated for such use, as explained in
Documentation/process/deprecated.rst. This change does not alter the
functionality or introduce any behavioral changes.
Signed-off-by: Rahul Kumar <rk0006818@gmail.com>
---
drivers/mtd/sm_ftl.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/mtd/sm_ftl.c b/drivers/mtd/sm_ftl.c
index abc7b186353f..575e137ce8f3 100644
--- a/drivers/mtd/sm_ftl.c
+++ b/drivers/mtd/sm_ftl.c
@@ -44,7 +44,8 @@ static ssize_t sm_attr_show(struct device *dev, struct device_attribute *attr,
struct sm_sysfs_attribute *sm_attr =
container_of(attr, struct sm_sysfs_attribute, dev_attr);
- strncpy(buf, sm_attr->data, sm_attr->len);
+ memcpy(buf, sm_attr->data, sm_attr->len);
+ buf[sm_attr->len] = '\0';
return sm_attr->len;
}
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mtd: sm_ftl: replace strncpy with memcpy
2025-09-03 12:17 [PATCH] mtd: sm_ftl: replace strncpy with memcpy Rahul Kumar
@ 2025-09-03 14:28 ` Pratyush Yadav
0 siblings, 0 replies; 2+ messages in thread
From: Pratyush Yadav @ 2025-09-03 14:28 UTC (permalink / raw)
To: Rahul Kumar
Cc: miquel.raynal, richard, vigneshr, linux-mtd, linux-kernel,
linux-kernel-mentees, skhan
On Wed, Sep 03 2025, Rahul Kumar wrote:
> Replace strncpy with memcpy in sm_attr_show and explicitly add a NUL
> terminator after the copy. This aligns with current kernel best practices
> as strncpy is deprecated for such use, as explained in
> Documentation/process/deprecated.rst. This change does not alter the
> functionality or introduce any behavioral changes.
>
> Signed-off-by: Rahul Kumar <rk0006818@gmail.com>
> ---
> drivers/mtd/sm_ftl.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/sm_ftl.c b/drivers/mtd/sm_ftl.c
> index abc7b186353f..575e137ce8f3 100644
> --- a/drivers/mtd/sm_ftl.c
> +++ b/drivers/mtd/sm_ftl.c
> @@ -44,7 +44,8 @@ static ssize_t sm_attr_show(struct device *dev, struct device_attribute *attr,
> struct sm_sysfs_attribute *sm_attr =
> container_of(attr, struct sm_sysfs_attribute, dev_attr);
>
> - strncpy(buf, sm_attr->data, sm_attr->len);
> + memcpy(buf, sm_attr->data, sm_attr->len);
> + buf[sm_attr->len] = '\0';
This writes one more byte than strncpy() (which would stop at
buf[sm_attr->len - 1]). Is this safe?
> return sm_attr->len;
Since you write sm_attr->len + 1 bytes now, I think this should also be
updated.
> }
--
Regards,
Pratyush Yadav
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-09-03 14:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-03 12:17 [PATCH] mtd: sm_ftl: replace strncpy with memcpy Rahul Kumar
2025-09-03 14:28 ` Pratyush Yadav
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox