Re: [PATCH] target/core: replace strncpy with strscpy

Martin K. Petersen
2025-07-29T03:09:38Z

Hi Pranav!

> As far as I looked, I could only find the following 4 instances of
> strncpy() for the file target_core_transport.c:
>
> target_core_transport.c:1115: strncpy(p_buf, buf, p_buf_len);
> target_core_transport.c:1165: strncpy(p_buf, buf, p_buf_len);
> target_core_transport.c:1225: strncpy(p_buf, buf, p_buf_len);
> target_core_transport.c:1279: strncpy(p_buf, buf, p_buf_len);
>
> And I have changed all of them in my patch. Kindly point me out to
> other instances, if I am missing any.

Sorry, I guess I didn't read far enough. I was focused on the VPD
identifier dump function and whether it could overrun the static buffer.

> Also, I intended this to be a cleanup patch for the deprecated
> strncpy() function and wanted to replace it with strscpy() which is
> encouraged. No functional changes were intended.

In our experience cleanup patches come with a very high risk of
introducing regressions. Regressions in the I/O stack could potentially
lead to issues such as systems failing to boot or people losing their
data. So we generally only merge patches if it can be demonstrated that
they fix an actual problem.

--
Martin K. Petersen