From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Bartlomiej Kubik <kubik.bartlomiej@gmail.com>
Cc: sathya.prakash@broadcom.com, kashyap.desai@broadcom.com,
sumit.saxena@broadcom.com, sreekanth.reddy@broadcom.com,
James.Bottomley@HansenPartnership.com,
martin.petersen@oracle.com, mpi3mr-linuxdrv.pdl@broadcom.com,
linux-scsi@vger.kernel.org, skhan@linuxfoundation.org,
david.hunter.linux@gmail.com,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH RESEND] driver/scsi/mpi3mr.h: Fix build warning for mpi3mr_start_watchdog
Date: Mon, 06 Oct 2025 22:25:15 -0400 [thread overview]
Message-ID: <yq1frbvforp.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20251002063038.552399-1-kubik.bartlomiej@gmail.com> (Bartlomiej Kubik's message of "Thu, 2 Oct 2025 08:30:38 +0200")
Hi Bartlomiej!
> Fix watchdog name truncation.
>
> In function mpi3mr_start_watchdog, watchdog_work_q_name is build
> snprintf(mrioc->watchdog_work_q_name,
> sizeof(mrioc->watchdog_work_q_name), "watchdog_%s%d", mrioc->name,
> mrioc->id);
> +#define MPI3MR_WATCHDOG_NAME_LENGTH (MPI3MR_NAME_LENGTH + 15)
Please document why 15 is the correct number and describe the code path
which leads to the watchdog name being truncated.
Also (and I guess this is a question for Broadcom since I don't have any
mpi3mr hardware so I can't check), as far as I can tell, mrioc->name
already includes mrioc->id so the id will be listed twice in the
watchdog name? Or am I missing something?
--
Martin K. Petersen
next prev parent reply other threads:[~2025-10-07 4:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-02 6:30 [PATCH RESEND] driver/scsi/mpi3mr.h: Fix build warning for mpi3mr_start_watchdog Bartlomiej Kubik
2025-10-07 2:25 ` Martin K. Petersen [this message]
2025-10-07 20:05 ` Bartłomiej Kubik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1frbvforp.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=david.hunter.linux@gmail.com \
--cc=kashyap.desai@broadcom.com \
--cc=kubik.bartlomiej@gmail.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mpi3mr-linuxdrv.pdl@broadcom.com \
--cc=sathya.prakash@broadcom.com \
--cc=skhan@linuxfoundation.org \
--cc=sreekanth.reddy@broadcom.com \
--cc=sumit.saxena@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox