From: Shuah Khan <skhan@linuxfoundation.org>
To: Pengfei Xu <pengfei.xu@intel.com>
Cc: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
Shuah Khan <shuah@kernel.org>, Qiuxu Zhuo <qiuxu.zhuo@intel.com>,
Heng Su <heng.su@intel.com>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
Kai Svahn <kai.svahn@intel.com>,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v4] selftests: tpm: upgrade TPM2 tests from Python 2 to Python 3
Date: Mon, 6 Jul 2020 14:12:01 -0600 [thread overview]
Message-ID: <02c7dda4-3a05-b118-1edf-ec020eb08193@linuxfoundation.org> (raw)
In-Reply-To: <20200703012005.GA23276@xpf-desktop.sh.intel.com>
On 7/2/20 7:20 PM, Pengfei Xu wrote:
> Thanks a lot Jarkko and Shuah!
>
> BR.
> Thanks!
>
> On 2020-07-02 at 15:32:49 -0600, Shuah Khan wrote:
>> On 7/2/20 1:44 PM, Jarkko Sakkinen wrote:
>>> On Fri, Jun 26, 2020 at 11:40:52AM +0800, Pengfei Xu wrote:
>>>> Python 2 is no longer supported by the Python upstream project, so
>>>> upgrade TPM2 tests to Python 3.
>>>>
>>>> Signed-off-by: Pengfei Xu <pengfei.xu@intel.com>
>>>
>>> I think that it's perfect now. Thank you.
>>>
>>> Also
>>>
>>> 1. I checked that scripts/checkpatch.pl did not report any errors.
>>> 2. sudo python3 -m unittest -v tpm2_tests.SmokeTest
>>> 3. sudo python3 -m unittest -v tpm2_tests.SpaceTest
>>>
>>> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
>>> Tested-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
>>>
>>> Shuah, I could pick this up after your PR (with my earlier fixes) lands
>>> to mainline, and sort out possible merge conflicts if they uprise. Is
>>> this fine by you?
>>>
>>
I started applying this and then passed.
Doesn't this test fail if python3 isn't installed? Do you have to
support both versions?
thanks,
-- Shuah
next prev parent reply other threads:[~2020-07-06 20:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-26 3:40 [PATCH v4] selftests: tpm: upgrade TPM2 tests from Python 2 to Python 3 Pengfei Xu
2020-07-02 19:44 ` Jarkko Sakkinen
2020-07-02 21:32 ` Shuah Khan
2020-07-03 1:20 ` Pengfei Xu
2020-07-06 20:12 ` Shuah Khan [this message]
2020-07-06 20:32 ` Shuah Khan
2020-07-06 23:02 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02c7dda4-3a05-b118-1edf-ec020eb08193@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=heng.su@intel.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=kai.svahn@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=pengfei.xu@intel.com \
--cc=qiuxu.zhuo@intel.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).