From: Shuah Khan <skhan@linuxfoundation.org>
To: Muhammad Usama Anjum <usama.anjum@collabora.com>,
Shuah Khan <shuah@kernel.org>
Cc: kernel@collabora.com, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH 1/2] selftests: x86: test_vsyscall: conform test to TAP format output
Date: Wed, 27 Mar 2024 10:17:37 -0600 [thread overview]
Message-ID: <069b0fc7-0f8c-42f6-9ba4-275fbd830912@linuxfoundation.org> (raw)
In-Reply-To: <0dacf491-29ec-4c24-927e-978056177648@collabora.com>
On 3/27/24 06:16, Muhammad Usama Anjum wrote:
> On 3/27/24 1:00 AM, Shuah Khan wrote:
>> On 3/14/24 04:32, Muhammad Usama Anjum wrote:
>>> Conform the layout, informational and status messages to TAP. No
>>> functional change is intended other than the layout of output messages.
>>> Without using TAP messages, the passed/failed/skip test names cannot be
>>> found.
>>>
>>> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
>>> ---
>>
>>
>> I am seeing lot more changes than conform and formatting changes.
> Counting total number of tests based on architecture was really difficult
> until the code needed to be moved around. I'll split this patch into 2. The
> first part would just simplify the test by moving functions around and use
> #ifdef precisely. The seconds part would convert it to the TAP.
>
Yes. That will make is easier to review and maintain.
thanks,
-- Shuah
prev parent reply other threads:[~2024-03-27 16:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-14 10:32 [PATCH 1/2] selftests: x86: test_vsyscall: conform test to TAP format output Muhammad Usama Anjum
2024-03-14 10:32 ` [PATCH 2/2] selftests: x86: test_mremap_vdso: " Muhammad Usama Anjum
2024-03-26 20:01 ` Shuah Khan
2024-03-25 7:08 ` [PATCH 1/2] selftests: x86: test_vsyscall: " Muhammad Usama Anjum
2024-03-26 20:00 ` Shuah Khan
2024-03-27 12:16 ` Muhammad Usama Anjum
2024-03-27 16:17 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=069b0fc7-0f8c-42f6-9ba4-275fbd830912@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=usama.anjum@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox