From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B772ED2FF for ; Thu, 6 Mar 2025 09:28:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741253310; cv=none; b=Om9zjMj+cgkByXKJ693Aq33MbRdCobivt4W7QFcwRKf0LbQGbm3yCNRJLr8mF7XaTcMBZdBpk4wcQnvGojYbnIk6x7+uyzuf4b2gdtHPRfpyl1w827BtL2oF890eBSzUX5KncspBhjyCJb9Vnv1vWjbRmt8WswKioK5Mg612QvU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741253310; c=relaxed/simple; bh=e1FU4/LUiVNBTqldIDpCuyOXjaB2MNtq2Q3AsgjVgO4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Rbt+37xePXk8Etu4CumbKGaFqEIQaJW+a3X1cczw+hkYeVC6XvnT0c8U9EAlQ1XrK6Iix2Ff1itzBP7i3nj59U6+vmN/9V/cm8XCxWDfDM2awi6M1buIjZHvEqsuOwK3BMCURvMLBDjEASVUaxQQdfBRltW6HvaGbMb73Cj5UWs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=jDvlQSYu; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="jDvlQSYu" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741253307; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=fgOIGFO0KNslC6ocif/kgfcUvHoBKSQ+gkoKczc7WGg=; b=jDvlQSYujQKuMgaOsHIOsYHvkEO7GTHec3+od0nKdUwkzxE2IRE0uO3kghBAXgTIUFjTED 1bPP1lTg5KzoYwlxSy+q0fXs4qLvXifzYLxv7LGg4ZpzU30zARLTbpJzbl8EsHgauwh04w HaUx3ze8orkT7cjv+wC8J3spC4J7/mE= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-510-mUPXXfiTNL6XVBKBURXSCQ-1; Thu, 06 Mar 2025 04:28:14 -0500 X-MC-Unique: mUPXXfiTNL6XVBKBURXSCQ-1 X-Mimecast-MFC-AGG-ID: mUPXXfiTNL6XVBKBURXSCQ_1741253293 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4393e89e910so1861425e9.0 for ; Thu, 06 Mar 2025 01:28:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741253293; x=1741858093; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=fgOIGFO0KNslC6ocif/kgfcUvHoBKSQ+gkoKczc7WGg=; b=T5pNOqJRQmItUiU9HkbieAaJ3iw5rCHQOU+SQKWH4+wK/ZzUw/OC2u1OazYGC5KM1h tkmguccOYpW9iOQLhxMU2T0UdcP1A5uhblCDiATYBQx+lSb0szju8yzDS7QhO90O3YSg PP1q4GMHzBIE7Aa2v5Pj3h5PVzU7qmRHGnPYR+cCXhQJlgbCiXsI3a1zX/q+Lktjyy8z UAuN+SDuG6UqQOYCVTk28WCZxrhUeBP4QehJjTnMPLFkjqWvT1mhAyZ5Y72RCE5r/XrN MryGceamQjUjzWbrPgmY63Oa4VwYVLQZpv0RIrEHJ1+Heg/B3MIqrPoI4YrOExVMlSLr YABA== X-Forwarded-Encrypted: i=1; AJvYcCXgrcm8tTXJKxfXiH2GUbUoEV5+cx3UIM/vjjezKX+jNd9+LqE+eRWR+ecUJQpsEJU1FOJ8qv8Fi42kDG7Bq5A=@vger.kernel.org X-Gm-Message-State: AOJu0YzRcTQDR6Jp53MJobJ2wbIh4a6HDMuiLmoiagZZRJ5A8b7yCsnw WZseDHrCbXWJqwmS6tRuHksOXNNYykI79QJInwrKa5jDDlkNR9hEAZd//qJ0qxXriRjoOlmzzp4 GauK3nWVX6zGgUzURlmz55rfuxMRFTmwD7FEXXuScxbLp4cZ5oGrvYdU2cA1xP2qf3A== X-Gm-Gg: ASbGnctrPps3QCUjHN7BQ8Y+M2FP/jwp1/BHR5lYQRxTzj10xdgKWHbpSYfyW5pVMsG briGR0/UVdeimPzDOkGbNp/25yPJcFekQ8vCSNbUYY5VoW2AXDytg7LBsuBSqYrxOxw/BTKfIFg EN+03avfgsQYPsYHTbPJxqCA666KYhwXaPzeohdwanzJ1nvJRDcV8KpnIa6p5fo3j3crtAhVCli 1dRpokYkn4DoObklHHTN82d4+QvFE2n0CikiJoL0qM/kGjlpMqwqnFZopj2yaaSvOyUAmqkSE69 h2uaOsqMVQa/4kItQllBVsehh5neFsmKcLZri0C++A5ujQ4qCVe9IyzpKwz3b+ueXtTun/DqLv2 vaPXG3lleiM1wWL7s0Ep4LJjER/veeC/5ZFrt+S/31fg= X-Received: by 2002:a5d:6c62:0:b0:390:e158:a1b8 with SMTP id ffacd0b85a97d-3911f7ca744mr6005778f8f.43.1741253293336; Thu, 06 Mar 2025 01:28:13 -0800 (PST) X-Google-Smtp-Source: AGHT+IGwciK0KkFRXPVUO9aQuqIhjlXAUuInlRk5dnn+MniJZY8Vq2QFnXscKZmGMNQehLBVRxPJog== X-Received: by 2002:a5d:6c62:0:b0:390:e158:a1b8 with SMTP id ffacd0b85a97d-3911f7ca744mr6005752f8f.43.1741253292990; Thu, 06 Mar 2025 01:28:12 -0800 (PST) Received: from ?IPV6:2003:cb:c74d:4400:2f98:9b35:6822:ce54? (p200300cbc74d44002f989b356822ce54.dip0.t-ipconnect.de. [2003:cb:c74d:4400:2f98:9b35:6822:ce54]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3912bfba66esm1470172f8f.18.2025.03.06.01.28.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Mar 2025 01:28:12 -0800 (PST) Message-ID: <08023d47-dcf4-4efb-bf13-5aef3c6dca14@redhat.com> Date: Thu, 6 Mar 2025 10:28:09 +0100 Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 08/10] selftests/mm: Skip gup_longerm tests on weird filesystems To: Brendan Jackman , Lorenzo Stoakes , Andrew Morton , Shuah Khan Cc: Dev Jain , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250228-mm-selftests-v3-0-958e3b6f0203@google.com> <20250228-mm-selftests-v3-8-958e3b6f0203@google.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250228-mm-selftests-v3-8-958e3b6f0203@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 28.02.25 17:54, Brendan Jackman wrote: > Some filesystems don't support funtract()ing unlinked files. They return > ENOENT. In that case, skip the test. > That's not documented in the man page, so is this a bug of these filesystems? What are examples for these weird filesystems? As we have the fstype available, we could instead simply reject more filesystems earlier. See fs_is_unknown(). > Signed-off-by: Brendan Jackman > --- > tools/testing/selftests/mm/gup_longterm.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/mm/gup_longterm.c b/tools/testing/selftests/mm/gup_longterm.c > index 879e9e4e8cce8127656fabe098abf7db5f6c5e23..494ec4102111b9c96fb4947b29c184735ceb8e1c 100644 > --- a/tools/testing/selftests/mm/gup_longterm.c > +++ b/tools/testing/selftests/mm/gup_longterm.c > @@ -96,7 +96,15 @@ static void do_test(int fd, size_t size, enum test_type type, bool shared) > int ret; > > if (ftruncate(fd, size)) { > - ksft_test_result_fail("ftruncate() failed (%s)\n", strerror(errno)); > + if (errno == ENOENT) { > + /* > + * This can happen if the file has been unlinked and the > + * filesystem doesn't support truncating unlinked files. > + */ > + ksft_test_result_skip("ftruncate() failed with ENOENT\n"); > + } else { > + ksft_test_result_fail("ftruncate() failed (%s)\n", strerror(errno)); > + } > return; > } > > -- Cheers, David / dhildenb