From: Shuah Khan <skhan@linuxfoundation.org>
To: Li Zhijian <lizhijian@fujitsu.com>,
linux-kselftest@vger.kernel.org, Shuah Khan <shuah@kernel.org>
Cc: linux-kernel@vger.kernel.org, Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH 1/3] selftests: Add a few missing gitignore files
Date: Tue, 15 Oct 2024 09:38:14 -0600 [thread overview]
Message-ID: <087279ce-7fd0-49f3-b578-2d1b82852e3d@linuxfoundation.org> (raw)
In-Reply-To: <20241015010817.453539-1-lizhijian@fujitsu.com>
On 10/14/24 19:08, Li Zhijian wrote:
> Binary files should be added to .gitignore
>
> 'git status' complains:
> Untracked files:
> (use "git add <file>..." to include in what will be committed)
> alsa/global-timer
> alsa/utimer-test
> filesystems/statmount/statmount_test_ns
> mm/hugetlb_dio
> mm/pkey_sighandler_tests_32
> mm/pkey_sighandler_tests_64
> net/netfilter/conntrack_reverse_clash
>
> Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
> ---
> tools/testing/selftests/alsa/.gitignore | 2 ++
> tools/testing/selftests/filesystems/statmount/.gitignore | 1 +
> tools/testing/selftests/mm/.gitignore | 2 ++
> tools/testing/selftests/net/netfilter/.gitignore | 1 +
You are sending 3 patches without a cover letter and you are missing
key people who should review the patches.
Combining several subsystem changes in one patch leads to merge
conflicts.
Run get_maintainers to see who all the patch should be sent.
> 4 files changed, 6 insertions(+)
>
> diff --git a/tools/testing/selftests/alsa/.gitignore b/tools/testing/selftests/alsa/.gitignore
> index 12dc3fcd3456..1407fd24a97b 100644
> --- a/tools/testing/selftests/alsa/.gitignore
> +++ b/tools/testing/selftests/alsa/.gitignore
> @@ -1,3 +1,5 @@
> mixer-test
> pcm-test
> test-pcmtest-driver
> +global-timer
> +utimer-test
> diff --git a/tools/testing/selftests/filesystems/statmount/.gitignore b/tools/testing/selftests/filesystems/statmount/.gitignore
> index 82a4846cbc4b..66a21f289453 100644
> --- a/tools/testing/selftests/filesystems/statmount/.gitignore
> +++ b/tools/testing/selftests/filesystems/statmount/.gitignore
> @@ -1,2 +1,3 @@
> # SPDX-License-Identifier: GPL-2.0-only
> /*_test
> +statmount_test_ns
> diff --git a/tools/testing/selftests/mm/.gitignore b/tools/testing/selftests/mm/.gitignore
> index da030b43e43b..2ac11b7fcb26 100644
> --- a/tools/testing/selftests/mm/.gitignore
> +++ b/tools/testing/selftests/mm/.gitignore
> @@ -51,3 +51,5 @@ hugetlb_madv_vs_map
> mseal_test
> seal_elf
> droppable
> +hugetlb_dio
> +pkey_sighandler_tests*
> diff --git a/tools/testing/selftests/net/netfilter/.gitignore b/tools/testing/selftests/net/netfilter/.gitignore
> index 0a64d6d0e29a..eef8d5784e94 100644
> --- a/tools/testing/selftests/net/netfilter/.gitignore
> +++ b/tools/testing/selftests/net/netfilter/.gitignore
> @@ -4,3 +4,4 @@ connect_close
> conntrack_dump_flush
> sctp_collision
> nf_queue
> +conntrack_reverse_clash
thanks,
-- Shuah
next prev parent reply other threads:[~2024-10-15 15:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-15 1:08 [PATCH 1/3] selftests: Add a few missing gitignore files Li Zhijian
2024-10-15 1:08 ` [PATCH 2/3] selftests/net: Fix ./ns-XXXXXX not cleanup Li Zhijian
2024-10-15 15:43 ` Jakub Kicinski
2024-10-15 1:08 ` [PATCH 3/3] selftests: ignore output files and clean them in Makefile Li Zhijian
2024-10-15 15:56 ` Shuah Khan
2024-10-15 15:38 ` Shuah Khan [this message]
2024-10-16 0:42 ` [PATCH 1/3] selftests: Add a few missing gitignore files Zhijian Li (Fujitsu)
2024-10-17 20:22 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=087279ce-7fd0-49f3-b578-2d1b82852e3d@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=lizhijian@fujitsu.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox