Linux Kernel Selftest development
 help / color / mirror / Atom feed
From: Shuah Khan <skhan@linuxfoundation.org>
To: sedat.dilek@gmail.com, Huang Rui <ray.huang@amd.com>
Cc: Doug Smythies <dsmythies@telus.net>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	"Meng, Li (Jassmine)" <Li.Meng@amd.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	linux-kselftest@vger.kernel.org,
	Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] selftests: amd-pstate: Don't delete source files via Makefile
Date: Fri, 20 Jan 2023 09:15:17 -0700	[thread overview]
Message-ID: <0a1ae8e9-ab0e-038a-084f-240f73489010@linuxfoundation.org> (raw)
In-Reply-To: <CA+icZUWP_uYr5B6d_xms5gpCRmNCx46KwukmZyuuTdEPawKUyA@mail.gmail.com>

On 1/20/23 09:11, Sedat Dilek wrote:
> On Fri, Jan 20, 2023 at 10:17 AM Huang Rui <ray.huang@amd.com> wrote:
>>
>> On Fri, Jan 20, 2023 at 01:54:01PM +0800, Doug Smythies wrote:
>>> Revert the portion of a recent Makefile change that incorrectly
>>> deletes source files when doing "make clean".

Ooo. That is bad.

>>>
>>> Fixes: ba2d788aa873 ("selftests: amd-pstate: Trigger tbench benchmark and test cpus")
>>> Reported-by: Sedat Dilek <sedat.dilek@gmail.com>
>>> Tested-by: Sedat Dilek <sedat.dilek@gmail.com>
>>> Signed-off-by: Doug Smythies <dsmythies@telus.net>
>>
>> (+ Shuah and linux-kselftest mailing list)
>>
>> Thanks for fix!
>>
>> Acked-by: Huang Rui <ray.huang@amd.com>
>>
> 
> [ I already replied - but with these important CCs ]
> 
> Hi Doug,
> 
> Thanks for the patch!
> 
> Small nit, I saw this with:

What did you see and should that be fixed as well.

> 
> $ make -C tools/ clean
> 
> Otherwise:
> 
> Reviewed-by: Sedat Dilek <sedat.dilek@gmail.com>
> 

Send me the revised patch with all the right CCs and I will pull
this right away.

thanks,
-- Shuah


  reply	other threads:[~2023-01-20 16:15 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <001201d92c93$98c8a040$ca59e0c0$@telus.net>
2023-01-20  9:17 ` [PATCH] selftests: amd-pstate: Don't delete source files via Makefile Huang Rui
2023-01-20 16:11   ` Sedat Dilek
2023-01-20 16:15     ` Shuah Khan [this message]
2023-01-20 16:20       ` Sedat Dilek
2023-01-20 16:23         ` Shuah Khan
2023-01-21 16:41 ` [PATCH v2] " Doug Smythies
2023-01-21 16:58   ` Sedat Dilek
2023-01-25 17:03   ` Shuah Khan
2023-01-26 22:43     ` Doug Smythies
2023-02-03 15:15   ` Guillaume Tucker
2023-02-03 16:26     ` Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0a1ae8e9-ab0e-038a-084f-240f73489010@linuxfoundation.org \
    --to=skhan@linuxfoundation.org \
    --cc=Li.Meng@amd.com \
    --cc=dsmythies@telus.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=ray.huang@amd.com \
    --cc=sedat.dilek@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox