From: Reinette Chatre <reinette.chatre@intel.com>
To: Jarkko Sakkinen <jarkko@kernel.org>
Cc: Shuah Khan <shuah@kernel.org>,
linux-sgx@vger.kernel.org,
Dave Hansen <dave.hansen@linux.intel.com>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/2] selftests/sgx: Migrate to kselftest harness
Date: Wed, 12 May 2021 08:56:03 -0700 [thread overview]
Message-ID: <0b68cf8e-994d-3c85-cb93-5701722d9336@intel.com> (raw)
In-Reply-To: <YJsrDc34d2vbc+At@kernel.org>
Hi Jarkko,
On 5/11/2021 6:10 PM, Jarkko Sakkinen wrote:
> On Tue, May 11, 2021 at 11:42:49AM -0700, Reinette Chatre wrote:
>> Hi Jarkko,
>>
>> On 5/7/2021 8:56 PM, Jarkko Sakkinen wrote:
>>> Migrate to kselftest harness. Use a fixture test with enclave initialized
>>> and de-initialized for each of the existing three tests, in other words:
>>>
>>> 1. One FIXTURE() for managing the enclave life-cycle.
>>> 2. Three TEST_F()'s, one for each test case.
>>
>> These changes make it easier to add tests and I think it is a valuable
>> addition.
>>
>>>
>>> This gives a leaps better reporting than before. Here's an example
>>> transcript:
>>>
>>> TAP version 13
>>> 1..3
>>> 0x0000000000000000 0x0000000000002000 0x03
>>> 0x0000000000002000 0x0000000000001000 0x05
>>> 0x0000000000003000 0x0000000000003000 0x03
>>> ok 1 enclave.unclobbered_vdso
>>> 0x0000000000000000 0x0000000000002000 0x03
>>> 0x0000000000002000 0x0000000000001000 0x05
>>> 0x0000000000003000 0x0000000000003000 0x03
>>> ok 2 enclave.clobbered_vdso
>>> 0x0000000000000000 0x0000000000002000 0x03
>>> 0x0000000000002000 0x0000000000001000 0x05
>>> 0x0000000000003000 0x0000000000003000 0x03
>>> ok 3 enclave.clobbered_vdso_and_user_function
>>>
>>
>> The output claims to conform to TAP13 but it does not seem as though all of
>> the output conforms to TAP13. I assume such output would confuse automated
>> systems.
>
> You mean
>
> 0x0000000000000000 0x0000000000002000 0x03
> 0x0000000000002000 0x0000000000001000 0x05
> 0x0000000000003000 0x0000000000003000 0x03
>
> ?
Yes
Reinette
next prev parent reply other threads:[~2021-05-12 16:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-08 3:56 [PATCH v4 1/2] selftests/sgx: Rename 'eenter' and 'sgx_call_vdso' Jarkko Sakkinen
2021-05-08 3:56 ` [PATCH v4 2/2] selftests/sgx: Migrate to kselftest harness Jarkko Sakkinen
2021-05-11 18:42 ` Reinette Chatre
2021-05-12 1:10 ` Jarkko Sakkinen
2021-05-12 15:56 ` Reinette Chatre [this message]
2021-05-12 19:17 ` Jarkko Sakkinen
2021-05-11 18:49 ` [PATCH v4 1/2] selftests/sgx: Rename 'eenter' and 'sgx_call_vdso' Dave Hansen
2021-05-12 1:14 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b68cf8e-994d-3c85-cb93-5701722d9336@intel.com \
--to=reinette.chatre@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=jarkko@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-sgx@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox