Linux Kernel Selftest development
 help / color / mirror / Atom feed
From: Carolina Jubran <cjubran@nvidia.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Shuah Khan <shuah@kernel.org>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S . Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>, Gal Pressman <gal@nvidia.com>,
	Tariq Toukan <tariqt@nvidia.com>,
	Cosmin Ratiu <cratiu@nvidia.com>, Nimrod Oren <noren@nvidia.com>,
	Mark Bloch <mbloch@nvidia.com>,
	linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
	netdev@vger.kernel.org
Subject: Re: [PATCH 3/3] selftests: drv-net: Relax total BW check in devlink_rate_tc_bw.py
Date: Mon, 8 Sep 2025 22:16:29 +0300	[thread overview]
Message-ID: <0cd98e25-b387-452b-b1a6-414ab20a4cf3@nvidia.com> (raw)
In-Reply-To: <20250905153243.6c03e257@kernel.org>


On 06/09/2025 1:32, Jakub Kicinski wrote:
> On Tue, 2 Sep 2025 16:21:01 -0700 Jakub Kicinski wrote:
>> On Sun, 31 Aug 2025 11:06:41 +0300 Carolina Jubran wrote:
>>> Because the measured total is the sum of two iperf3 streams that do not
>>> always start or stop at the same time
>> That's solvable, tho? iperf3 has --json support, it will give you
>> the b/w readings in the configured intervals (1sec by default).
>> With the interval based samples at hand you should be able to select
>> only the period in which b/w is stable ("middle" of the test).
>>
>> While at it it may make sense to switch to lib/py/load.py wrappers
>> rather than threading the python locally in the test.
> Hi Carolina! I think you replied to me but the reply never reached
> the list, I purged it from my inbox before realizing.
:O Sorry about that
> I think you said that the direction of the flows is wrong for load.py.
Yes, that’s exactly what I said.
> Perhaps adding a reverse= attr which will translate the --reverse in
> the client process would do?

However, I’ll also need to extend load.py:

1. Binding support to ensure traffic flows through the specific VLAN
     interface.
2. Interval-based measurement for iperf3 --json to analyze only the
     stable period.

So my plan is:

1. Send v2 for net to fix the current test with interval-based
     measurement.
2. Follow up with a patch to extend load.py with reverse/binding/interval
     support and then migrate the test to use it.

Does that sound good to you?

Thanks again for the suggestion :)


  reply	other threads:[~2025-09-08 19:16 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-31  8:06 [PATCH 0/3] selftests: drv-net: Fix issues in devlink_rate_tc_bw.py Carolina Jubran
2025-08-31  8:06 ` [PATCH 1/3] selftests: drv-net: Fix and clarify TC bandwidth split " Carolina Jubran
2025-09-01 15:45   ` Simon Horman
2025-08-31  8:06 ` [PATCH 2/3] selftests: drv-net: Fix tolerance calculation " Carolina Jubran
2025-09-01 15:45   ` Simon Horman
2025-08-31  8:06 ` [PATCH 3/3] selftests: drv-net: Relax total BW check " Carolina Jubran
2025-09-01 15:46   ` Simon Horman
2025-09-02 23:21   ` Jakub Kicinski
2025-09-05 22:32     ` Jakub Kicinski
2025-09-08 19:16       ` Carolina Jubran [this message]
2025-09-08 20:19         ` Jakub Kicinski
2025-09-09 10:06           ` Carolina Jubran
2025-09-09 21:04             ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0cd98e25-b387-452b-b1a6-414ab20a4cf3@nvidia.com \
    --to=cjubran@nvidia.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=cratiu@nvidia.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=gal@nvidia.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=mbloch@nvidia.com \
    --cc=netdev@vger.kernel.org \
    --cc=noren@nvidia.com \
    --cc=pabeni@redhat.com \
    --cc=shuah@kernel.org \
    --cc=tariqt@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox