Re: [PATCH v3 25/29] selftests/resctrl: Introduce generalized test framework

Reinette Chatre
2023-12-13T22:00:35Z

Hi Ilpo,

On 12/11/2023 4:18 AM, Ilpo Järvinen wrote:
> Each test currently has a "run test" function in per test file and
> another resctrl_tests.c. The functions in resctrl_tests.c are almost
> identical.
>
> Generalize the one in resctrl_tests.c such that it can be shared
> between all of the tests. It makes adding new tests easier and removes
> the per test if () forests.
>
> Also add comment to CPU vendor IDs that they must be defined as bits
> for a bitmask.
>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette