From: Dave Hansen <dave.hansen@intel.com>
To: Dionna Amalie Glaze <dionnaglaze@google.com>,
Kuppuswamy Sathyanarayanan
<sathyanarayanan.kuppuswamy@linux.intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, Shuah Khan <shuah@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
"H . Peter Anvin" <hpa@zytor.com>,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
Tony Luck <tony.luck@intel.com>,
Wander Lairson Costa <wander@redhat.com>,
Erdem Aktas <erdemaktas@google.com>,
Chong Cai <chongc@google.com>, Qinkun Bao <qinkun@apache.org>,
Guorui Yu <GuoRui.Yu@linux.alibaba.com>,
Du Fan <fan.du@intel.com>,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-doc@vger.kernel.org
Subject: Re: [PATCH v2 3/3] selftests/tdx: Test GetQuote TDX attestation feature
Date: Thu, 27 Apr 2023 12:53:52 -0700 [thread overview]
Message-ID: <10248ba6-c5d4-47dd-03e0-0500d4c4a621@intel.com> (raw)
In-Reply-To: <CAAH4kHb_PAhR5jLFi2KsGku9ALNtjtxb-JO-k1ULK-Mj5mi=pw@mail.gmail.com>
On 4/26/23 08:47, Dionna Amalie Glaze wrote:
>> +/* Helper function to get TDREPORT */
>> +long get_tdreport0(int devfd, struct tdx_report_req *req)
>> +{
>> + int i;
>> +
>> + /* Generate sample report data */
>> + for (i = 0; i < TDX_REPORTDATA_LEN; i++)
>> + req->reportdata[i] = i;
>> +
> Shouldn't req be zeroed before populating reportdata? We wouldn't want
> uninitialized memory to leave the guest. I know this is just a test,
> but it's best to model good practices for anyone that might
> copy/paste.
It's leaving the guest and going to the TDX module. What's the problem
there?
next prev parent reply other threads:[~2023-04-27 19:54 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-13 3:41 [PATCH v2 0/3] TDX Guest Quote generation support Kuppuswamy Sathyanarayanan
2023-04-13 3:41 ` [PATCH v2 1/3] x86/tdx: Add TDX Guest event notify interrupt support Kuppuswamy Sathyanarayanan
2023-04-14 13:34 ` Huang, Kai
2023-04-25 23:47 ` Sathyanarayanan Kuppuswamy
2023-04-26 1:59 ` Huang, Kai
2023-04-26 6:07 ` Sathyanarayanan Kuppuswamy
2023-04-28 13:50 ` Huang, Kai
2023-04-13 3:41 ` [PATCH v2 2/3] virt: tdx-guest: Add Quote generation support Kuppuswamy Sathyanarayanan
2023-04-26 15:40 ` Dionna Amalie Glaze
2023-04-27 18:27 ` Sathyanarayanan Kuppuswamy
2023-04-28 1:29 ` Dionna Amalie Glaze
2023-04-28 13:49 ` Huang, Kai
2023-05-01 6:03 ` Sathyanarayanan Kuppuswamy
2023-05-01 12:48 ` Huang, Kai
2023-05-04 7:12 ` Sathyanarayanan Kuppuswamy
2023-05-04 12:00 ` Huang, Kai
2023-05-02 22:27 ` Chong Cai
2023-04-13 3:41 ` [PATCH v2 3/3] selftests/tdx: Test GetQuote TDX attestation feature Kuppuswamy Sathyanarayanan
2023-04-26 15:47 ` Dionna Amalie Glaze
2023-04-27 19:10 ` Sathyanarayanan Kuppuswamy
2023-04-27 19:56 ` Dave Hansen
2023-04-27 19:53 ` Dave Hansen [this message]
2023-05-10 0:10 ` [PATCH v2 0/3] TDX Guest Quote generation support Erdem Aktas
2023-05-10 0:14 ` Sathyanarayanan Kuppuswamy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10248ba6-c5d4-47dd-03e0-0500d4c4a621@intel.com \
--to=dave.hansen@intel.com \
--cc=GuoRui.Yu@linux.alibaba.com \
--cc=bp@alien8.de \
--cc=chongc@google.com \
--cc=corbet@lwn.net \
--cc=dave.hansen@linux.intel.com \
--cc=dionnaglaze@google.com \
--cc=erdemaktas@google.com \
--cc=fan.du@intel.com \
--cc=hpa@zytor.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=qinkun@apache.org \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=wander@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox