From: Shuah Khan <skhan@linuxfoundation.org>
To: Muhammad Usama Anjum <usama.anjum@collabora.com>,
Shuah Khan <shuah@kernel.org>
Cc: kernel@collabora.com, "Chang S . Bae" <chang.seok.bae@intel.com>,
Binbin Wu <binbin.wu@linux.intel.com>,
Ingo Molnar <mingo@kernel.org>,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH 2/2] selftests: x86: vdso_restorer: Return correct exit statuses
Date: Tue, 16 Jul 2024 16:01:19 -0600 [thread overview]
Message-ID: <11c8d108-8635-4c57-b76a-8dc4a9c908af@linuxfoundation.org> (raw)
In-Reply-To: <20240712073045.110014-2-usama.anjum@collabora.com>
On 7/12/24 01:30, Muhammad Usama Anjum wrote:
> Return correct exit status, KSFT_SKIP if the pre-conditions aren't met.
> Return KSFT_FAIL if error occurs. Use ksft_finished() which will
> compmare the total planned tests with passed tests to return the exit
> value.
>
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
Same comment - here. Include before and after output to show
how this change improves the report.
thanks,
-- Shuah
next prev parent reply other threads:[~2024-07-16 22:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-12 7:30 [PATCH 1/2] selftests: x86: vdso_restorer: remove manual counting of pass/fail tests Muhammad Usama Anjum
2024-07-12 7:30 ` [PATCH 2/2] selftests: x86: vdso_restorer: Return correct exit statuses Muhammad Usama Anjum
2024-07-16 22:01 ` Shuah Khan [this message]
2024-07-18 7:18 ` Muhammad Usama Anjum
2024-07-16 22:00 ` [PATCH 1/2] selftests: x86: vdso_restorer: remove manual counting of pass/fail tests Shuah Khan
2024-07-19 16:40 ` Shuah Khan
2024-07-21 16:24 ` Muhammad Usama Anjum
2024-07-21 16:37 ` Muhammad Usama Anjum
2024-07-22 17:20 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11c8d108-8635-4c57-b76a-8dc4a9c908af@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=binbin.wu@linux.intel.com \
--cc=chang.seok.bae@intel.com \
--cc=kernel@collabora.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=shuah@kernel.org \
--cc=usama.anjum@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox