From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72877ECAAD8 for ; Tue, 13 Sep 2022 16:28:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231570AbiIMQ2Y (ORCPT ); Tue, 13 Sep 2022 12:28:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54998 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232009AbiIMQ15 (ORCPT ); Tue, 13 Sep 2022 12:27:57 -0400 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7AC80AE208; Tue, 13 Sep 2022 08:23:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663082615; x=1694618615; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=Xv3LSLJmI60OwaQZNgO6wmG3l4up4OQb63JFCEM8X4Q=; b=J7nmIPvcJmoGibWc1aqkwUtC6QNghmadigMSA6jhq/wl8GHQzgcPjVAV QZSGS3NMJtxkts268Y3y7L9bs0UkSyKesx/aBX0qIiWugVhM93J4Tr0wN SOO22aUGtfH2m6SfM4ese9D3llYXqNK+ecsZyUuIb6v3E2yQiu+uR4QIf AehfrUA6iFjiQn8ivPxLPYYSUPcsPoKYGQpwBCIuc4NAJX4bM4//3kqvd RerbOZQgfbDkB8NWU0pofa+XxhFd0sCYd32LPGi1jlwewvEQ8GdgXoUUO vQC6DANfR64EQvVtkKGPSfsoytbS6smHF9GH4blh8xp0/ATLasyjognjt A==; X-IronPort-AV: E=McAfee;i="6500,9779,10469"; a="277897879" X-IronPort-AV: E=Sophos;i="5.93,313,1654585200"; d="scan'208";a="277897879" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Sep 2022 08:21:23 -0700 X-IronPort-AV: E=Sophos;i="5.93,313,1654585200"; d="scan'208";a="646969211" Received: from liweian-mobl.amr.corp.intel.com (HELO [10.209.26.112]) ([10.209.26.112]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Sep 2022 08:21:22 -0700 Message-ID: <11c9a594-4012-c648-829b-6bd410d2415d@linux.intel.com> Date: Tue, 13 Sep 2022 08:21:22 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.11.0 Subject: Re: [PATCH v13 1/3] x86/tdx: Add TDX Guest attestation interface driver Content-Language: en-US To: Dave Hansen , "Huang, Kai" , "tglx@linutronix.de" , "mingo@redhat.com" , "shuah@kernel.org" , "x86@kernel.org" , "bp@alien8.de" , "dave.hansen@linux.intel.com" Cc: "linux-kernel@vger.kernel.org" , "ak@linux.intel.com" , "gregkh@linuxfoundation.org" , "wander@redhat.com" , "tim.gardner@canonical.com" , "hpa@zytor.com" , "isaku.yamahata@gmail.com" , "kirill.shutemov@linux.intel.com" , "Luck, Tony" , "khalid.elmously@canonical.com" , "marcelo.cerri@canonical.com" , "Cox, Philip" , "linux-doc@vger.kernel.org" , "linux-kselftest@vger.kernel.org" References: <20220909192708.1113126-1-sathyanarayanan.kuppuswamy@linux.intel.com> <20220909192708.1113126-2-sathyanarayanan.kuppuswamy@linux.intel.com> <4a4ed638-d505-6f30-bf0f-a16a32d494a4@intel.com> From: Sathyanarayanan Kuppuswamy In-Reply-To: <4a4ed638-d505-6f30-bf0f-a16a32d494a4@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org Hi, On 9/13/22 2:01 AM, Dave Hansen wrote: > On 9/12/22 19:44, Sathyanarayanan Kuppuswamy wrote: >>> and include the header ( ?) for memchr_inv()? >> One of the previous headers includes linux/string.h (I am not sure which one). >> So why include it explicitly? > Because it's a best practice. What happens is that you ride along on > the coat tails of another #include, someone sees that include is no > longer used and removes it. Then, your code is busted on some weird > .config. > > *OR*, the header itself changes and doesn't #include the dependency you > need. > > I guess you can go add this advice to Documentation/ if it's not there > already somewhere. Ok. I will include it explicitly. -- Sathyanarayanan Kuppuswamy Linux Kernel Developer