From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84F78377034 for ; Sat, 10 Oct 2026 14:02:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791640954; cv=none; b=szGbe8WNAGIYHlrV8UgLK86v7e4hXcIE8/3cA2hxfpuJ3CLx6gNnCzrSKy+cw+ovWmdVZ+6p6DboSsEm6I+zws5dlyUjiZkPLJC1sL8Ipd6vxB0aYMDOOQoFAI8+mU6MSpcbnVmZbPXCHsqMCituideVJPxX2P80nPsAjHplZvU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791640954; c=relaxed/simple; bh=1nn/gxCVP607cWus+kYr5yIsKr+fX0D4lXIQhCvbtzw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=dQX6ShCGoFyT/juKXfHcI80j7j166xTNychshSQNTVBK9hCF6W1IU4oyti8kwdbPTToU6sCtT9yQ6oyd3lvBhrdBe5ZFwCmBAwyCKUcNALY3K3nAKafjlzplVsBYxEP7+eKlgisLsSMKkCnzdhJwcfn7j8pcVNjk7VGDfPJ6/10= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=qDSQdYr2; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qDSQdYr2" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-48c4d99c32bso541608f8f.1 for ; Sat, 10 Oct 2026 07:02:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791640950; x=1792245750; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=7F23FNsErj3fpOWKD/UF72cX4yQCCC/yv71F53gfj74=; b=qDSQdYr2Z/+mdWr5U9bMM5gDAIS4cjZD0yDeCyIfsFfHYpIe/gYGLc/dT9OQDe5ZyM pr1zGnzEzFNtrH3AraRLJ6Ba7MLXvgw8eAvI2boZA1c+xLYps7STj05CZ2fsPMO1pFEs nXqebZNvonbBefAXm8QHluLwoyANWBzBWD2LAoyzeIuVMJRSXsczb6rAIB2iefqSw1e+ QadP+/LKkS0pvPI4VX4T5PfEo0OuISIWLLWf+iqvMkOG29pP1YKP9igsoEcRVEjjDIyV K3PQn1aap2b2S6seVp+UJo6X/+taOuJZj0PqkoCpHWbR1SQkTGsaOB1LGjaoGFe+MiDC H1wA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791640950; x=1792245750; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=7F23FNsErj3fpOWKD/UF72cX4yQCCC/yv71F53gfj74=; b=YYm1xfJTtgBD9Ny7MJQbJUy4o+pNvfKDlhmU4VD/JJBbT97HNK9+55GHA5t1kfKjcO sJWp8+752/big5GFpTsrCqhptalQmzDPOfx/WhNl79he1S4z5jGSf136VS/A5aun8Kpp oPdkT40u4J0v36OdUOnnD2B956Rr4HB5t7RHSkVEQKqaX6YBTNk2YMTibNSMm4FL/10V EqnIi3HD/3AEUPrHFS1wOAz8l6MxMoQJEwyU+TQ8NRhgfmPxAvTEluvcRDUqv46/a3e9 Jm2Dv91nIyEzrDSZ4dNSW4NOsC40r8D5qLnEW8BogAmt70SIrSMiLlg0cSTIg0jrnzL9 PzDQ== X-Forwarded-Encrypted: i=1; AKwUvBxaV2It9GXrX6OsUDeXjGwbeApDDpDXAtF+TzJr3gXpj1iWI8jYYwtbmutxfj/xgyEe3+VeUl6NhLzz2PT6/nY=@vger.kernel.org X-Gm-Message-State: AFq9FYLG9MQ/b7lTWgEW3/jXhHwYXJf/0pOzjCXQ+cY+VpRMC1iW4nW6 7hnIQ1A/sZRCrh9bxG3QXKpTAmwcT0KX+/IOd2Oq+5Uu8rpr5OJV3E+Q X-Gm-Gg: AYBFou0dXrOeJ+ZcIBWNKFHlVpgShxevBk7Ak0euX9xDpo/vKmCGiHrtUHsurStwok/ k4fSCO5CxpBywmXAwxYv0mXmzIaoYr3EyvPsE8T5pkKVxo63N1LRbLwkT4Xqaw9cuyuvgKoVF9m izXTGvKIFOZHfUqMwhtigAadyTpSj1JQXP2QB+LINIxp18YDEnTKCD0p0FCePQ7VH+Pvv+8tRJu Z+mbEvXkWTYe/yrKAyvaG0xpJ18NLn2/ymqbHgnMnZyp1p83vqgC7s6UoL3g6GetdMegeS3Dc7g JjZPW4NR5hwhOSQhdMHzxDR9t8lKiQTQ+XfuNBMLoPkSBA25JV00yMZyQSpIYhdccxh8wboNj89 l0RibGcNTH8XFUj/VO2qVJnJBG/51wDZ2PY7CeroDB+GJStn7zplYgQBUi/0v5dNAcaZ/AbcDMH vJLADVNModx5gct8Q9wREZF2VASHACQOJdZP8SRLIzge6smdf9CkoIvIB+sjEupsrAlwF/ZsRY3 TNpJuyzNntEzMR63hEym4gC0zgHqXcJp2Bc8LQTztVcy8l5ZxgK61y8ZM7KaAyED7YxmnnCGi1I gE3CCa+P4S5m2o60HE/IfwCxOLqFiCF4QpzJza3XS3aHe66y X-Received: by 2002:a5d:6992:0:b0:48c:49bd:62df with SMTP id ffacd0b85a97d-48dba77d1ddmr7509477f8f.1.1791640950478; Sat, 10 Oct 2026 07:02:30 -0700 (PDT) Received: from ?IPV6:2a01:4b00:bd21:4f00:7cc6:d3ca:494:116c? ([2a01:4b00:bd21:4f00:7cc6:d3ca:494:116c]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48db9463499sm8727077f8f.3.2026.10.10.07.02.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 10 Oct 2026 07:02:29 -0700 (PDT) Message-ID: <12d8d2fc-6b3a-432f-b27d-e27bea01d697@gmail.com> Date: Sat, 10 Oct 2026 15:02:26 +0100 Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net v1 1/4] net: devmem: unmap dma_buf synchronously on queue uninstall To: Mina Almasry , Jakub Kicinski , David Wei , Taehee Yoo , Stanislav Fomichev , Paolo Abeni , Kaiyuan Zhang , Bobby Eshleman , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Simon Horman , Shuah Khan , Sumit Semwal , =?UTF-8?Q?Christian_K=C3=B6nig?= , Daniel Borkmann , Nikolay Aleksandrov , Tariq Toukan , Kaifeng Wang References: <20261010025532.839559-1-almasrymina@google.com> <20261010025532.839559-2-almasrymina@google.com> Content-Language: en-US From: Pavel Begunkov In-Reply-To: <20261010025532.839559-2-almasrymina@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/10/26 03:55, Mina Almasry wrote: > When a bound net_device is unregistered while userspace still holds a > netlink or TCP socket reference on a devmem binding, > mp_dmabuf_devmem_uninstall() clears binding->dev to NULL so > netdev_nl_sock_priv_destroy() will not touch the unregistered > net_device, but leaves the dma_buf attachment mapped until > __net_devmem_dmabuf_binding_free() runs later on socket close. > > Because dma_buf_attach() does not take a reference on dma_dev, device > removal frees dma_dev while the attachment is still mapped. Closing the > netlink socket afterwards triggers a slab use-after-free in > dma_unmap_sg_attrs(): > > BUG: KASAN: slab-use-after-free in dma_unmap_sg_attrs+0x76/0x2b0 > Read of size 8 at addr ffff88810fae64b0 by task kworker/3:1/53 > Workqueue: events __net_devmem_dmabuf_binding_free > Call Trace: > dma_unmap_sg_attrs+0x76/0x2b0 > unmap_udmabuf+0x8e/0x100 > dma_buf_unmap_attachment+0x145/0x330 > dma_buf_unmap_attachment_unlocked+0x96/0x130 > __net_devmem_dmabuf_binding_free+0x156/0x2e0 > Freed by task 9: > kfree+0x1b8/0x550 > nsim_bus_dev_release+0xe/0x60 > device_release+0xcf/0x250 > > Add net_devmem_dmabuf_binding_unmap() serialized under binding->lock > and null out binding->sgt and binding->attachment after unmapping so > unmapping is idempotent across queue uninstall and deferred binding > destruction. Call it synchronously when the last bound RX queue is > uninstalled in mp_dmabuf_devmem_uninstall(). > > Fixes: f8350a4358fc ("net: page_pool: add a mp hook to unregister_netdevice*") It looks more like 170aafe35cb98e0f3fbacb446ea86389fbce22ea ("netdev: support binding dma-buf to netdevice"). The one in the tag didn't do anything interesting. The fix looks good as well, might be a good idea to clear net_iov's dma_addr as well. Reviewed-by: Pavel Begunkov -- Pavel Begunkov