From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f44.google.com (mail-ot1-f44.google.com [209.85.210.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE30C29D26E for ; Tue, 14 Oct 2025 06:28:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760423315; cv=none; b=fTGBAdce5KQ8xKINOzIyMiRYOJjRK+N2CKsoI+W0eitjL69KIEFw6P8/4QAmNL5SvBhKjvBJB71coT+K5RAI0tnwEriVhqLGVNQxTixK/ormZOgyeA3e2CbbfOAXul6N4Xv/HTRN+BKb8cDHolnq3zNVTYpDxYTo+slEWoQoVcE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760423315; c=relaxed/simple; bh=OpDb8zcmf7OOOUcsljWtaBvRup8+IOw7WICjSqXWuEE=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References: MIME-Version:Content-Type; b=lM6yOuTZCdfTxQpDc/keY9YLD+9lglyVPikLRATO5Dbt9Yi5+frMrI2QwbBlO6H9F35lNaERm3wEpnez1Cqx8jK236gvifcgf43m6T8JmhWCZ9JlwHoWBJg8A5SCkt4o+EB1oaxWfKNRIUvsfLmppsWOJlfED121WmAgby6MaRU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=l6v6uzQV; arc=none smtp.client-ip=209.85.210.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="l6v6uzQV" Received: by mail-ot1-f44.google.com with SMTP id 46e09a7af769-7b4f7a855baso3417815a34.3 for ; Mon, 13 Oct 2025 23:28:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1760423312; x=1761028112; darn=vger.kernel.org; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=brM2AXzbshOug5S8YTD/rMQwcF1ZQ1CEjKwrbSaUSno=; b=l6v6uzQV7BveO2h89PmRTKoHW8euu9I+keWirj34S0msvsJW2fBEG+HQhQXHtVZRyZ bAmYTGJHxisFUgCov0+FcZe5K3abP4f2iZQ1Mn8bqT1S5RdQ5PBur1UZht0L9S11fGL9 qvghedPpPUz2aOXxXqme5WX3y1mfUmjSYsaQfIKUId1PlcXO3i6iGhpRgl9QMDKyZQIm p/ozVMclJLwaU7GrB/cH5E3zGZTbcBdanWzalRPrUD7jI774MtRkJCGCAMYwWOcp9/nR uJ2MuQ+FFOGkY5hm9dqA9Nb7ZFoYr/vo+y60HABh2tfrPuBcSM3/LfuL472B1WxPBJ25 5sBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760423312; x=1761028112; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=brM2AXzbshOug5S8YTD/rMQwcF1ZQ1CEjKwrbSaUSno=; b=FKDADjsEgPsQ5s089noSQIMmYv3noQvSsY/VrWFvCKPnYgY4dthvanJTTyOzFZDivU TtifXUdSMBd0rbgq3cLa1OfbK61hRqkv/nSmETyoCibAU5YtXe0jgFVGvoRFAUifasgI E+T7DrCT80Sr7KMm+6cfXQklAWmyd4qyt7PmBi76Cntb3Nu3SRSopF/G3U1RaU66BTXy MLrUUfNnOxpFuKQjdXLF1DAK13YpR7sJejZM9y+0/x4NW78/SJtl9yF9S/qHywfFQMFw O67rbhh7HXzVhXNgrt7apwHWI54KHicltpRvVpdqMNPEvwCogcHmI2NzwdkzOk2lOIfL ygNg== X-Forwarded-Encrypted: i=1; AJvYcCXg4uh+AWmL8OzTQC7pjTCkcbfOI+H4Fhtxf6ADCjQ/27C//Oyw/kHfwulEp/w+ZelsRo8Dl5Nk8jtAW+eni54=@vger.kernel.org X-Gm-Message-State: AOJu0YwUbpY8yDx7RIUlr1Ql0Ux2XVFtxCRTHUa8ICVBFnICyFUBsnjy wxMEPSB8dOshLVZdwEuLJBc369r8WAepOlXg1kfirukOIdffq/fsYu/eIF88ib7W9Q== X-Gm-Gg: ASbGncvaOW3p116pqa+UeTIMmbO53d4dOEmK5IcdrwiXg3YFZG1DhwAGfBRIF2gpkDA faY/9b5AcU20BpKDIC3VvJ6thkQjSiKqgVs9/b7koq3UiNMtIG9JxRV9yyB7whKPM4cFtPbgRS+ NiCh/ywr9B5/q/ps2IlLk2D+T3A9lxDUf4EielC5qJSwtiDyRVr6ABT3QmtzKYsuId0CT2G7Z2p 4Kro0E48CghorhKgUDsmNio+XXYZZHP2z54bpQ8JvdMHmx0tRgA4YkhRDpnTK0xwso6pB2HZvvr YFS638foSjTOhKxKNAAJWrrXMPWNR/scsYIBemyQ9RT46kaI68jrvEZHx0dj77ic+6lfPwBQxaH e99otcsB/7y0qu0I10WOi9Ww6ktX7KoeR3CscOOMx5JTkVl6ZKiqKFM7n3i9g1T4hR7Jz0y+PSh e1zVcSz52ASj8bY+O8spK5C2Jmor94ZzP4 X-Google-Smtp-Source: AGHT+IHpAC62Y/PpF9N39pOEV4oQ+R34+qD97A9mi5Ss82ojK2v3fSuKrUmSuLa+MCNnAOAp+Ihp0w== X-Received: by 2002:a05:6830:710c:b0:744:f113:fef8 with SMTP id 46e09a7af769-7c0df7becc1mr11002097a34.35.1760423311621; Mon, 13 Oct 2025 23:28:31 -0700 (PDT) Received: from darker.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7c0f915eed4sm4209133a34.36.2025.10.13.23.28.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Oct 2025 23:28:30 -0700 (PDT) Date: Mon, 13 Oct 2025 23:28:16 -0700 (PDT) From: Hugh Dickins To: Kalesh Singh cc: akpm@linux-foundation.org, minchan@kernel.org, lorenzo.stoakes@oracle.com, david@redhat.com, Liam.Howlett@oracle.com, rppt@kernel.org, pfalcato@suse.de, kernel-team@android.com, android-mm@google.com, stable@vger.kernel.org, SeongJae Park , Alexander Viro , Christian Brauner , Jan Kara , Kees Cook , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Jann Horn , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Ben Segall , Mel Gorman , Valentin Schneider , Shuah Khan , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v3 1/5] mm: fix off-by-one error in VMA count limit checks In-Reply-To: <20251013235259.589015-2-kaleshsingh@google.com> Message-ID: <144f3ee6-1a5f-57fc-d5f8-5ce54a3ac139@google.com> References: <20251013235259.589015-1-kaleshsingh@google.com> <20251013235259.589015-2-kaleshsingh@google.com> Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Mon, 13 Oct 2025, Kalesh Singh wrote: > The VMA count limit check in do_mmap() and do_brk_flags() uses a > strict inequality (>), which allows a process's VMA count to exceed > the configured sysctl_max_map_count limit by one. > > A process with mm->map_count == sysctl_max_map_count will incorrectly > pass this check and then exceed the limit upon allocation of a new VMA > when its map_count is incremented. > > Other VMA allocation paths, such as split_vma(), already use the > correct, inclusive (>=) comparison. > > Fix this bug by changing the comparison to be inclusive in do_mmap() > and do_brk_flags(), bringing them in line with the correct behavior > of other allocation paths. > > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > Cc: > Cc: Andrew Morton > Cc: David Hildenbrand > Cc: "Liam R. Howlett" > Cc: Lorenzo Stoakes > Cc: Mike Rapoport > Cc: Minchan Kim > Cc: Pedro Falcato > Reviewed-by: David Hildenbrand > Reviewed-by: Lorenzo Stoakes > Reviewed-by: Pedro Falcato > Acked-by: SeongJae Park > Signed-off-by: Kalesh Singh > --- > > Changes in v3: > - Collect Reviewed-by and Acked-by tags. > > Changes in v2: > - Fix mmap check, per Pedro > > mm/mmap.c | 2 +- > mm/vma.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/mmap.c b/mm/mmap.c > index 644f02071a41..da2cbdc0f87b 100644 > --- a/mm/mmap.c > +++ b/mm/mmap.c > @@ -374,7 +374,7 @@ unsigned long do_mmap(struct file *file, unsigned long addr, > return -EOVERFLOW; > > /* Too many mappings? */ > - if (mm->map_count > sysctl_max_map_count) > + if (mm->map_count >= sysctl_max_map_count) > return -ENOMEM; > > /* > diff --git a/mm/vma.c b/mm/vma.c > index a2e1ae954662..fba68f13e628 100644 > --- a/mm/vma.c > +++ b/mm/vma.c > @@ -2797,7 +2797,7 @@ int do_brk_flags(struct vma_iterator *vmi, struct vm_area_struct *vma, > if (!may_expand_vm(mm, vm_flags, len >> PAGE_SHIFT)) > return -ENOMEM; > > - if (mm->map_count > sysctl_max_map_count) > + if (mm->map_count >= sysctl_max_map_count) > return -ENOMEM; > > if (security_vm_enough_memory_mm(mm, len >> PAGE_SHIFT)) > -- > 2.51.0.760.g7b8bcc2412-goog Sorry for letting you go so far before speaking up (I had to test what I believed to be true, and had hoped that meanwhile one of your many illustrious reviewers would say so first, but no): it's a NAK from me. These are not off-by-ones: at the point of these checks, it is not known whether an additional map/vma will have to be added, or the addition will be merged into an existing map/vma. So the checks err on the lenient side, letting you get perhaps one more than the sysctl said, but not allowing any more than that. Which is all that matters, isn't it? Limiting unrestrained growth. In this patch you're proposing to change it from erring on the lenient side to erring on the strict side - prohibiting merges at the limit which have been allowed for many years. Whatever one thinks about the merits of erring on the lenient versus erring on the strict side, I see no reason to make this change now, and most certainly not with a Fixes Cc: stable. There is no danger in the current behaviour; there is danger in prohibiting what was allowed before. As to the remainder of your series: I have to commend you for doing a thorough and well-presented job, but I cannot myself see the point in changing 21 files for what almost amounts to a max_map_count subsystem. I call it misdirected effort, not at all to my taste, which prefers the straightforward checks already there; but accept that my taste may be out of fashion, so won't stand in the way if others think it worthwhile. Hugh