From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55654C001E0 for ; Mon, 31 Jul 2023 20:23:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229762AbjGaUXs (ORCPT ); Mon, 31 Jul 2023 16:23:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47964 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229510AbjGaUXr (ORCPT ); Mon, 31 Jul 2023 16:23:47 -0400 Received: from mail-io1-xd33.google.com (mail-io1-xd33.google.com [IPv6:2607:f8b0:4864:20::d33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9F0DE133 for ; Mon, 31 Jul 2023 13:23:46 -0700 (PDT) Received: by mail-io1-xd33.google.com with SMTP id ca18e2360f4ac-7748ca56133so44398539f.0 for ; Mon, 31 Jul 2023 13:23:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1690835026; x=1691439826; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=oGlGpw5Q9q73Ldn1HOpDYO0OQxBN9y2wWaW04aAn3Sk=; b=Tzp6pkj2CuiwN5T1cb6RwqAagJWZcZvIWhojOmZqsie7v+OMp3a42BkMHG4DsZYbKG JX6vDuwGJ0pF1vlwG8N+kns4UsUCyfy1wrYHeeJ6XSiLVu7AEcyYPIusG4cwY3hIs11d qk1xcXcs7N34m6JIPDF+z3ZnMXQObG47f0meQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690835026; x=1691439826; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oGlGpw5Q9q73Ldn1HOpDYO0OQxBN9y2wWaW04aAn3Sk=; b=K03/qNvgNuHhVgqc4u9achDFWcrjSj4ZG9Uhf6lxXcLSdsQvcDU1pRGsP6EfZLXvAl P2AEBD0rtWChHzmrvqpwoRk9awnlcafNJ2EZsWol3LowFDQlSfBgN+rnigKl8gLemRQ3 AQYumoztC2RQkqYywOTYCTADJHZd03kjYqE/deehoUjrbRmuorSk+ZyPFVtvyGZdcHU0 nUrgooQSGwbznhrTuu+m9InCJAqKSS+rANPpLa111D1xvA9LSfcy21RqSlTk5mRnzHIn ODCrIFPG2g/GoCq3jmhcjdAKAfvLa9ymewUlJFjztQV+1zGmoKRiA6EPTuykC5JCt9AX h0NA== X-Gm-Message-State: ABy/qLZ83zd6sUZsOd4VlcpISxCQbk3zBOBKxQnYJCCqV88FQTgxUkPi sGwHWgK2/XfNarTKR2D3zim+hvP3Hvx4qiTrcxSk8g== X-Google-Smtp-Source: APBJJlGgAux994dW83HtYTYpLYqmK0Zrk10pegL7O2Y8RxVDCrof5T1fCXszRhNuvGJTRoXVR7UiwQ== X-Received: by 2002:a6b:c9d3:0:b0:788:2d78:813c with SMTP id z202-20020a6bc9d3000000b007882d78813cmr8761031iof.0.1690835026049; Mon, 31 Jul 2023 13:23:46 -0700 (PDT) Received: from [192.168.1.128] ([38.15.45.1]) by smtp.gmail.com with ESMTPSA id j12-20020a02cb0c000000b004290985a1efsm3239825jap.43.2023.07.31.13.23.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 31 Jul 2023 13:23:45 -0700 (PDT) Message-ID: <1471f593-1ff5-902a-a045-9241feda7bd0@linuxfoundation.org> Date: Mon, 31 Jul 2023 14:23:45 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [RESEND PATCH v2] selftests:connector: Fix input argument error paths to skip Content-Language: en-US To: shuah@kernel.org, Liam.Howlett@oracle.com, anjali.k.kulkarni@oracle.com, kuba@kernel.org Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: <20230729002403.4278-1-skhan@linuxfoundation.org> From: Shuah Khan In-Reply-To: <20230729002403.4278-1-skhan@linuxfoundation.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On 7/28/23 18:24, Shuah Khan wrote: > Fix input argument parsing paths to skip from their error legs. > This fix helps to avoid false test failure reports without running > the test. > > Signed-off-by: Shuah Khan > --- > v2: Removed root check based on Anjali's review comments. > Add netdev to RESEND > > tools/testing/selftests/connector/proc_filter.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/connector/proc_filter.c b/tools/testing/selftests/connector/proc_filter.c > index 4fe8c6763fd8..4a825b997666 100644 > --- a/tools/testing/selftests/connector/proc_filter.c > +++ b/tools/testing/selftests/connector/proc_filter.c > @@ -248,7 +248,7 @@ int main(int argc, char *argv[]) > > if (argc > 2) { > printf("Expected 0(assume no-filter) or 1 argument(-f)\n"); > - exit(1); > + exit(KSFT_SKIP); > } > > if (argc == 2) { > @@ -256,7 +256,7 @@ int main(int argc, char *argv[]) > filter = 1; > } else { > printf("Valid option : -f (for filter feature)\n"); > - exit(1); > + exit(KSFT_SKIP); > } > } > Hi Jakub, I sent v2 for patch 3 in the series. Do you want me to send the entire series again with this revised 3rd patch. thanks, -- Shuah