From: Frank Rowand <frowand.list@gmail.com>
To: Mark Brown <broonie@kernel.org>, kernelci@groups.io, rmoar@google.com
Cc: "Bird, Tim" <Tim.Bird@sony.com>,
"davidgow@google.com" <davidgow@google.com>,
"skhan@linuxfoundation.org" <skhan@linuxfoundation.org>,
"keescook@chromium.org" <keescook@chromium.org>,
"brendanhiggins@google.com" <brendanhiggins@google.com>,
"corbet@lwn.net" <corbet@lwn.net>,
"guillaume.tucker@collabora.com" <guillaume.tucker@collabora.com>,
"dlatypov@google.com" <dlatypov@google.com>,
"kunit-dev@googlegroups.com" <kunit-dev@googlegroups.com>,
"linux-kselftest@vger.kernel.org"
<linux-kselftest@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [KTAP V2 PATCH] ktap_v2: add skip test result
Date: Wed, 15 Mar 2023 16:45:29 -0500 [thread overview]
Message-ID: <155efcdb-2be6-16c4-42bc-37930639060a@gmail.com> (raw)
In-Reply-To: <4568b302-2a5a-4499-b2f7-12f89c031495@sirena.org.uk>
On 3/15/23 07:53, Mark Brown wrote:
> On Tue, Mar 14, 2023 at 06:03:59PM -0400, Rae Moar via groups.io wrote:
>
>> One thing to note on the created churn: I have noticed a proportion of
>> kselftests currently implement skipped tests in a way that does not
>> use the SKIP directive. They use a comment of the format "# [SKIP]"
>> prior to a test result line with no SKIP directive. Thus, in order to
>> reach KTAP compliance the way skip tests are handled would need to be
>> changed in these cases anyways.
>
> This is the documented way of reporting a skip in KTAP:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/dev-tools/ktap.rst#n97
>
> TBH I'm finding it really hard to summon much enthusiasm for changing
> this except as part of some other incompatible update - the current
> format isn't ideal but deploying a change would be a bunch of hassle for
> the existing test automation systems.
Yes, there is no need to do a single specification change that results
in incompatibility. But given the previous discussions there seem to
be plenty of other desired changes that will result in incompatibility.
My desire is to take our time to capture as much of the desired changes
as possible in version 2 of the specification. And an expectation that
there will not need to be a version 3 of the specification for many years.
I will support not rushing version 2 of the specification so that this
goal can be realized.
next prev parent reply other threads:[~2023-03-15 21:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-10 22:20 [KTAP V2 PATCH] ktap_v2: add skip test result Rae Moar
2023-03-11 17:36 ` Bird, Tim
2023-03-12 4:02 ` Frank Rowand
2023-03-14 22:03 ` Rae Moar
2023-03-15 12:53 ` Mark Brown
2023-03-15 21:45 ` Frank Rowand [this message]
2023-03-16 11:33 ` Mark Brown
2023-03-16 17:49 ` Frank Rowand
2023-03-12 3:14 ` Frank Rowand
2023-03-12 3:25 ` Frank Rowand
2023-03-12 3:52 ` Frank Rowand
2023-03-13 14:41 ` Frank Rowand
2023-03-26 23:36 ` Frank Rowand
2023-03-14 22:20 ` Rae Moar
2023-03-15 13:08 ` Guillaume Tucker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=155efcdb-2be6-16c4-42bc-37930639060a@gmail.com \
--to=frowand.list@gmail.com \
--cc=Tim.Bird@sony.com \
--cc=brendanhiggins@google.com \
--cc=broonie@kernel.org \
--cc=corbet@lwn.net \
--cc=davidgow@google.com \
--cc=dlatypov@google.com \
--cc=guillaume.tucker@collabora.com \
--cc=keescook@chromium.org \
--cc=kernelci@groups.io \
--cc=kunit-dev@googlegroups.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=rmoar@google.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox