From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE5EDC19F2C for ; Wed, 3 Aug 2022 14:32:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229487AbiHCOcR (ORCPT ); Wed, 3 Aug 2022 10:32:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51716 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236594AbiHCOcQ (ORCPT ); Wed, 3 Aug 2022 10:32:16 -0400 Received: from mail-io1-xd29.google.com (mail-io1-xd29.google.com [IPv6:2607:f8b0:4864:20::d29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CCCE21A076 for ; Wed, 3 Aug 2022 07:32:14 -0700 (PDT) Received: by mail-io1-xd29.google.com with SMTP id q124so69365iod.3 for ; Wed, 03 Aug 2022 07:32:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=/j3Fr9QfRk1x010uV68rYVXfeBewZsxPUcsGA68QruU=; b=ZT3M9S40JMm27FIyb88LE0A+y31FE3ad/p6C/2XVdnxiIhnM2OFNQ1iGSQ9l+zGNPL fhOl6eg9vCmzgIEHGt66RUNLluN+PHl9v8eoy9SDJkTtUBL8odKOA35IwkxOMPVfyAV9 /2PiWH9AkH6iVsy/TEqhuNrzE+97ete50KaRk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=/j3Fr9QfRk1x010uV68rYVXfeBewZsxPUcsGA68QruU=; b=MAtFDdJyh6ss/RiFmoGGio8wx1CSt2wnz2UGVQQjwrDjfhciLpFgt9Z/RpWbbtcYQB w6ZCr8LCKXjnZXZXOU0tIgbENhgWPkTrx9j3tKtuQfbQovDBf5vunqfsuaCuOJqIRlyG Sqt4VA5J+EJZRW+bTPMpywD/nhI5FnRHOQUkC8NNM/kNP0Nc2KjTNumRaECeSaLuVg9x 2nh2JttHV6ZtIxSaMqSh2Jh/C/5XWEkTRsxBzGlR1tnVKfHphH6n0oOXruRSt5ohXzK/ ypvRpwXhG4KMj+MHAPCLTThhr8btu/OIkOBt6eBfOa9ybSSbky96HRMmK87GR9+c6GXk aQcA== X-Gm-Message-State: AJIora9lJ+wiSN7f4e63/mzXMedrjv3+y55SXeDi1FvgQWtpwCll6922 L1rxD+nh8NZK+X4cLx/xQQ2alQ== X-Google-Smtp-Source: AGRyM1vZ69hqTbQsygxpXIz1EH0kGCtYdQTsYCzbIYHN2gVW/05TXgy8zPaYnUUdx0aEW/r+fqyxYg== X-Received: by 2002:a6b:6911:0:b0:67b:f03b:74c1 with SMTP id e17-20020a6b6911000000b0067bf03b74c1mr8859031ioc.58.1659537134101; Wed, 03 Aug 2022 07:32:14 -0700 (PDT) Received: from [192.168.1.128] ([38.15.45.1]) by smtp.gmail.com with ESMTPSA id z7-20020a056e02088700b002de213ddb31sm1721276ils.71.2022.08.03.07.32.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Aug 2022 07:32:13 -0700 (PDT) Subject: Re: [GIT PULL] Kselftest update for Linux 5.20-rc1 To: Guillaume Tucker , =?UTF-8?Q?Micka=c3=abl_Sala=c3=bcn?= , Linus Torvalds Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Masahiro Yamada , linux-security-module , Shuah Khan References: <430ef132-2ac7-e1be-68ed-3d9c27382143@linuxfoundation.org> <2838c247-0648-3828-efb3-e11d7a0616b2@digikod.net> <84560b65-12ed-da24-3698-45484f80802a@linuxfoundation.org> From: Shuah Khan Message-ID: <15a23d4b-ee26-a6a1-a785-b640c550bfb8@linuxfoundation.org> Date: Wed, 3 Aug 2022 08:32:12 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On 8/2/22 10:44 PM, Guillaume Tucker wrote: > On 02/08/2022 15:29, Shuah Khan wrote: >> On 8/2/22 3:51 AM, Mickaël Salaün wrote: >>> Hi, >>> >>> This change breaks the Landlock test build when performed on the tools/testing/selftests/landlock directory because the (non-system/up-to-date) kernel headers aren't found. Looking at the use of top_srcdir and HDR_PATH, it seems that multiple subsystems are using this feature. I consider this change a regression. >>> >> >> I did a build test from the top level before sending the pull request >> and didn't catch this breakage as a result. This breaks when build is >> run from the test directory. >> >> We have had several problems related to khdr_dir and target and decided >> to move away from it with this change. >> >>> It also removes the check on up-to-date kernel headers (thanks to the Makefile's target timestamp). >>> >>> I wasn't CCed for this change impacting Landlock [1]. Please keep in mind to add at least maintainers and related mailing-lists for changes on related subsystems. >>> >> >> That is the usual practice and if I notice missing maintainers, I add >> them. We missed this one. >> >>> The following patch almost revert commit a917dd94b832 ("selftests/landlock: drop deprecated headers dependency") and partially fixes commit 49de12ba06ef ("selftests: drop KSFT_KHDR_INSTALL make target"): >>> >> >> Guillaume, >> >> Will you be able to look at this and send a patch on top? I will >> send another pull request before merge window closes? > > Sure, I'll take a look today. > Thank you. > Also I'll see if we can add some extra build tests in KernelCI > for the kselftest tree to catch issues like these automatically. > Yes. Adding tests to catch these automatically will be great. Please refer to use-cases for kselftest for tips on tests to add. Beig able to build from individual test directory is one of the use-cases. thanks, -- Shuah