From: patchwork-bot+netdevbpf@kernel.org
To: Maxim Mikityanskiy <maximmi@nvidia.com>
Cc: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
kafai@fb.com, songliubraving@fb.com, yhs@fb.com,
john.fastabend@gmail.com, kpsingh@kernel.org, shuah@kernel.org,
revest@chromium.org, davemarchevsky@fb.com,
linux-kselftest@vger.kernel.org, bpf@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH bpf] bpf: Fix the test_task_vma selftest to support output shorter than 1 kB
Date: Fri, 03 Dec 2021 23:00:08 +0000 [thread overview]
Message-ID: <163857240888.22727.1341673704180599136.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20211130181811.594220-1-maximmi@nvidia.com>
Hello:
This patch was applied to bpf/bpf-next.git (master)
by Daniel Borkmann <daniel@iogearbox.net>:
On Tue, 30 Nov 2021 20:18:11 +0200 you wrote:
> The test for bpf_iter_task_vma assumes that the output will be longer
> than 1 kB, as the comment above the loop says. Due to this assumption,
> the loop becomes infinite if the output turns to be shorter than 1 kB.
> The return value of read_fd_into_buffer is 0 when the end of file was
> reached, and len isn't being increased any more.
>
> This commit adds a break on EOF to handle short output correctly. For
> the reference, this is the contents that I get when running test_progs
> under vmtest.sh, and it's shorter than 1 kB:
>
> [...]
Here is the summary with links:
- [bpf] bpf: Fix the test_task_vma selftest to support output shorter than 1 kB
https://git.kernel.org/bpf/bpf-next/c/da54ab14953c
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2021-12-03 23:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-30 18:18 [PATCH bpf] bpf: Fix the test_task_vma selftest to support output shorter than 1 kB Maxim Mikityanskiy
2021-12-03 23:00 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=163857240888.22727.1341673704180599136.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davemarchevsky@fb.com \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=maximmi@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=revest@chromium.org \
--cc=shuah@kernel.org \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox