From: patchwork-bot+netdevbpf@kernel.org
To: Guillaume Nault <gnault@redhat.com>
Cc: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org,
shuah@kernel.org, linux-kselftest@vger.kernel.org,
idosch@mellanox.com, jiri@mellanox.com
Subject: Re: [PATCH net-next] selftests: fib offload: use sensible tos values
Date: Fri, 04 Feb 2022 03:20:10 +0000 [thread overview]
Message-ID: <164394481054.31803.1317546149481406185.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <5e43b343720360a1c0e4f5947d9e917b26f30fbf.1643826556.git.gnault@redhat.com>
Hello:
This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 2 Feb 2022 19:30:28 +0100 you wrote:
> Although both iproute2 and the kernel accept 1 and 2 as tos values for
> new routes, those are invalid. These values only set ECN bits, which
> are ignored during IPv4 fib lookups. Therefore, no packet can actually
> match such routes. This selftest therefore only succeeds because it
> doesn't verify that the new routes do actually work in practice (it
> just checks if the routes are offloaded or not).
>
> [...]
Here is the summary with links:
- [net-next] selftests: fib offload: use sensible tos values
https://git.kernel.org/netdev/net-next/c/bafe517af299
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2022-02-04 3:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-02 18:30 [PATCH net-next] selftests: fib offload: use sensible tos values Guillaume Nault
2022-02-02 19:10 ` Ido Schimmel
2022-02-02 19:46 ` Shuah Khan
2022-02-02 20:16 ` Guillaume Nault
2022-02-02 21:10 ` Shuah Khan
2022-02-02 23:25 ` Guillaume Nault
2022-02-02 23:29 ` Shuah Khan
2022-02-04 3:20 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=164394481054.31803.1317546149481406185.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=davem@davemloft.net \
--cc=gnault@redhat.com \
--cc=idosch@mellanox.com \
--cc=jiri@mellanox.com \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox