From: Shuah Khan <skhan@linuxfoundation.org>
To: CGEL <cgel.zte@gmail.com>, Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <will@kernel.org>, Shuah Khan <shuah@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
Jing Yangyang <jing.yangyang@zte.com.cn>,
Zeal Robot <zealci@zte.com.cn>,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH linux-next] tools:signal: fix boolreturn.cocci warnings
Date: Tue, 24 Aug 2021 08:39:10 -0600 [thread overview]
Message-ID: <16561a4f-6043-cc5b-7a50-5be1ff10bfa5@linuxfoundation.org> (raw)
In-Reply-To: <20210824065131.60346-1-deng.changcheng@zte.com.cn>
On 8/24/21 12:51 AM, CGEL wrote:
> From: Jing Yangyang <jing.yangyang@zte.com.cn>
>
> ./tools/testing/selftests/arm64/signal/test_signals_utils.h:112:9-10
> WARNING: return of 0/1 in function 'get_current_context' with
> return type bool
>
> Return statements in functions returning bool should use true/false
> instead of 1/0.
>
> Generated by: scripts/coccinelle/misc/boolreturn.cocci
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Jing Yangyang <jing.yangyang@zte.com.cn>
> ---
> tools/testing/selftests/arm64/signal/test_signals_utils.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/arm64/signal/test_signals_utils.h b/tools/testing/selftests/arm64/signal/test_signals_utils.h
> index 6772b5c..66122e6 100644
> --- a/tools/testing/selftests/arm64/signal/test_signals_utils.h
> +++ b/tools/testing/selftests/arm64/signal/test_signals_utils.h
> @@ -109,7 +109,7 @@ static __always_inline bool get_current_context(struct tdescr *td,
> if (seen_already) {
> fprintf(stdout,
> "Unexpected successful sigreturn detected: live_uc is stale !\n");
> - return 0;
> + return false;
> }
> seen_already = 1;
>
>
We can't accept this patch. The from and Signed-off-by don't match.
thanks,
-- Shuah
next prev parent reply other threads:[~2021-08-24 14:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-24 6:51 [PATCH linux-next] tools:signal: fix boolreturn.cocci warnings CGEL
2021-08-24 14:39 ` Shuah Khan [this message]
2021-08-25 20:04 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16561a4f-6043-cc5b-7a50-5be1ff10bfa5@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=catalin.marinas@arm.com \
--cc=cgel.zte@gmail.com \
--cc=jing.yangyang@zte.com.cn \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=will@kernel.org \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).