From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-186.mta0.migadu.com (out-186.mta0.migadu.com [91.218.175.186]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1075817F51A for ; Wed, 3 Jul 2024 21:39:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.186 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720042793; cv=none; b=mWWzaE3W5CYd0nBu/iNAG3JMxLlL+OfkKbNl5evKQ4h5w8cO5TI5Aaxv6gVnD7lSK8F4VJ/MUpW7TetmCcxqnF6mYSIOLutFeQRnL8zLSnqJEahHtrfviY9eT0ypdJzfj3LYcIkUAhjP2ExH2VoGN/Nxo70k5BD05lsXn3QqMlQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720042793; c=relaxed/simple; bh=EL4p3JfG51k3juRcgfI6CObDN5/EKiaTsr6WUa7E1uA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=tLumsJrbg5Gme/Fhi57oqNL84xI1jqzBM1ZTR0qO5vknPYb9ay+NbDp8dqBVpr+HQ+St6Lumx+yqU8ZqmLH/oXcUMGL8xymlUbbe+66A/qMFAC+Ec+GWTQmCLI6wlxFN56rOLjMDhkGy1zfCAUqaLiQ6cs/fZ2srQpKupjr/A/o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=NBwy4BT4; arc=none smtp.client-ip=91.218.175.186 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="NBwy4BT4" X-Envelope-To: geliang@kernel.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1720042790; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rgnjdw0C9ojFomnIwwPGyZhr9MxPLZEI4qlAOq/Td0k=; b=NBwy4BT4F0JdPG/THS+XqW3DQJNdn1+qj9GD+IQqCJ8C9ohEMdR7X4U6SlaccuNjTwKjA+ wKPkd3B8PYAGQlGuUgejH3Kz7W4e8xSO8YA8WSFlHWjc0D6Mh6CDdz+XfGiwPLJiEsZSpN vqpgP01M1ogg/E+pEe4Qji5fqlXowP8= X-Envelope-To: andrii@kernel.org X-Envelope-To: eddyz87@gmail.com X-Envelope-To: mykolal@fb.com X-Envelope-To: ast@kernel.org X-Envelope-To: daniel@iogearbox.net X-Envelope-To: song@kernel.org X-Envelope-To: yonghong.song@linux.dev X-Envelope-To: john.fastabend@gmail.com X-Envelope-To: kpsingh@kernel.org X-Envelope-To: sdf@google.com X-Envelope-To: haoluo@google.com X-Envelope-To: jolsa@kernel.org X-Envelope-To: shuah@kernel.org X-Envelope-To: tanggeliang@kylinos.cn X-Envelope-To: bpf@vger.kernel.org X-Envelope-To: linux-kselftest@vger.kernel.org Message-ID: <16e5a48e-3261-4e8f-a4f3-0e4b9cb16482@linux.dev> Date: Wed, 3 Jul 2024 14:39:44 -0700 Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH bpf-next v6 2/9] selftests/bpf: Use start_server_str in sockmap_ktls To: Geliang Tang Cc: Andrii Nakryiko , Eduard Zingerman , Mykola Lysenko , Alexei Starovoitov , Daniel Borkmann , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Shuah Khan , Geliang Tang , bpf@vger.kernel.org, linux-kselftest@vger.kernel.org References: <549f4b0a22ee953a57ebd3d96a5a6619e881b110.1719623708.git.tanggeliang@kylinos.cn> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Martin KaFai Lau In-Reply-To: <549f4b0a22ee953a57ebd3d96a5a6619e881b110.1719623708.git.tanggeliang@kylinos.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 6/28/24 6:20 PM, Geliang Tang wrote: > static void test_sockmap_ktls_disconnect_after_delete(int family, int map) > { > + struct network_helper_opts opts = { > + .backlog = SOMAXCONN, > + }; > struct sockaddr_storage addr = {0}; > socklen_t len = sizeof(addr); > int err, cli, srv, zero = 0; > > - srv = tcp_server(family); > + srv = start_server_str(family, SOCK_STREAM, NULL, 0, &opts); > if (srv == -1) It should be "if (!ASSERT_GE(srv, 0, ...))" to ensure that the failure is caught by the test_progs.