Linux Kernel Selftest development
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Charlie Jenkins <charlie@rivosinc.com>
Cc: Palmer Dabbelt <palmer@dabbelt.com>,
	linux-riscv@lists.infradead.org,
	 Jisheng Zhang <jszhang@kernel.org>,
	linux-kselftest@vger.kernel.org,
	 Samuel Holland <samuel@sholland.org>,
	 Paul Walmsley <paul.walmsley@sifive.com>,
	Jonathan Corbet <corbet@lwn.net>,
	 Albert Ou <aou@eecs.berkeley.edu>,
	Conor Dooley <conor@kernel.org>,
	 linux-kernel@vger.kernel.org, Andy Chiu <andy.chiu@sifive.com>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Chen-Yu Tsai <wens@csie.org>,  Shuah Khan <shuah@kernel.org>,
	linux-sunxi@lists.linux.dev,  devicetree@vger.kernel.org,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	 Evan Green <evan@rivosinc.com>,
	linux-doc@vger.kernel.org,  Guo Ren <guoren@kernel.org>
Subject: Re: [PATCH 02/13] dt-bindings: thead: add a vlen register length property
Date: Mon, 10 Jun 2024 00:27:09 -0600	[thread overview]
Message-ID: <171800082930.1000302.5109301877296329341.robh@kernel.org> (raw)
In-Reply-To: <20240609-xtheadvector-v1-2-3fe591d7f109@rivosinc.com>


On Sun, 09 Jun 2024 21:45:07 -0700, Charlie Jenkins wrote:
> Add a property analogous to the vlenb CSR so that software can detect
> the vector length of each CPU prior to it being brought online.
> Currently software has to assume that the vector length read from the
> boot CPU applies to all possible CPUs. On T-Head CPUs implementing
> pre-ratification vector, reading the th.vlenb CSR may produce an illegal
> instruction trap, so this property is required on such systems.
> 
> Signed-off-by: Charlie Jenkins <charlie@rivosinc.com>
> ---
>  Documentation/devicetree/bindings/riscv/thead.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/riscv/thead.yaml: 'thead,vlenb' is not one of ['$id', '$schema', 'title', 'description', 'examples', 'required', 'allOf', 'anyOf', 'oneOf', 'definitions', '$defs', 'additionalProperties', 'dependencies', 'dependentRequired', 'dependentSchemas', 'patternProperties', 'properties', 'not', 'if', 'then', 'else', 'unevaluatedProperties', 'deprecated', 'maintainers', 'select', '$ref']
	from schema $id: http://devicetree.org/meta-schemas/base.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240609-xtheadvector-v1-2-3fe591d7f109@rivosinc.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  reply	other threads:[~2024-06-10  6:27 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-10  4:45 [PATCH 00/13] riscv: Add support for xtheadvector Charlie Jenkins
2024-06-10  4:45 ` [PATCH 01/13] dt-bindings: riscv: Add xtheadvector ISA extension description Charlie Jenkins
2024-06-11 12:06   ` Guo Ren
2024-06-11 17:51     ` Charlie Jenkins
2024-06-10  4:45 ` [PATCH 02/13] dt-bindings: thead: add a vlen register length property Charlie Jenkins
2024-06-10  6:27   ` Rob Herring (Arm) [this message]
2024-06-10 16:29   ` Conor Dooley
2024-06-10 16:38     ` Charlie Jenkins
2024-06-10 19:28       ` Conor Dooley
2024-06-10  4:45 ` [PATCH 03/13] riscv: dts: allwinner: Add xtheadvector to the D1/D1s devicetree Charlie Jenkins
2024-06-10 17:49   ` Jessica Clarke
2024-06-10 17:51     ` Charlie Jenkins
2024-06-10  4:45 ` [PATCH 04/13] riscv: Add thead and xtheadvector as a vendor extension Charlie Jenkins
2024-06-10  4:45 ` [PATCH 05/13] riscv: vector: Use vlenb from DT for thead Charlie Jenkins
2024-06-10 17:51   ` Jessica Clarke
2024-06-10 18:10     ` Charlie Jenkins
2024-06-10  4:45 ` [PATCH 06/13] RISC-V: define the elements of the VCSR vector CSR Charlie Jenkins
2024-06-10  4:45 ` [PATCH 07/13] riscv: csr: Add CSR encodings for VCSR_VXRM/VCSR_VXSAT Charlie Jenkins
2024-06-10  4:45 ` [PATCH 08/13] riscv: Add xtheadvector instruction definitions Charlie Jenkins
2024-06-10  4:45 ` [PATCH 09/13] riscv: vector: Support xtheadvector save/restore Charlie Jenkins
2024-06-10  4:45 ` [PATCH 10/13] riscv: hwprobe: Add thead vendor extension probing Charlie Jenkins
2024-06-10 16:50   ` Evan Green
2024-06-10 17:36     ` Charlie Jenkins
2024-06-10  4:45 ` [PATCH 11/13] riscv: hwprobe: Document thead vendor extensions and xtheadvector extension Charlie Jenkins
2024-06-10  4:45 ` [PATCH 12/13] selftests: riscv: Fix vector tests Charlie Jenkins
2024-06-10  4:45 ` [PATCH 13/13] selftests: riscv: Support xtheadvector in " Charlie Jenkins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=171800082930.1000302.5109301877296329341.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=andy.chiu@sifive.com \
    --cc=aou@eecs.berkeley.edu \
    --cc=charlie@rivosinc.com \
    --cc=conor@kernel.org \
    --cc=corbet@lwn.net \
    --cc=devicetree@vger.kernel.org \
    --cc=evan@rivosinc.com \
    --cc=guoren@kernel.org \
    --cc=jernej.skrabec@gmail.com \
    --cc=jszhang@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=samuel@sholland.org \
    --cc=shuah@kernel.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox