Re: [PATCH net-next V2 13/13] selftests: drv-net: psp: Add a test for PSP with HW-GRO

[Cosmin Ratiu <cratiu@nvidia.com>]

On Tue, 2026-08-04 at 14:05 -0400, Daniel Zahka wrote:
> 
> 
> On 8/4/26 4:35 AM, Tariq Toukan wrote:
> > From: Cosmin Ratiu <cratiu@nvidia.com>
> > 
> > Add a test case which attempts to send several 64K chunks over PSP,
> > which is more than MTU, and thus trigger GSO on the TX side and HW
> > GRO
> > on the RX side. Verify HW GRO counters increase.
> > 
> > This required the addition of a new command in the psp responder,
> > so it
> > sends the data in order to get it reassembled on the local (DUT)
> > side.
> > 
> > Signed-off-by: Cosmin Ratiu <cratiu@nvidia.com>
> > Reviewed-by: Dragos Tatulea <dtatulea@nvidia.com>
> > Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
> > ---
> >   tools/testing/selftests/drivers/net/psp.py    | 131
> > ++++++++++++++++--
> >   .../selftests/drivers/net/psp_responder.c     |  49 +++++++
> >   2 files changed, 171 insertions(+), 9 deletions(-)
> > 
> > diff --git a/tools/testing/selftests/drivers/net/psp.py
> > b/tools/testing/selftests/drivers/net/psp.py
> > index 315648a770d0..9b899723a635 100755
> > --- a/tools/testing/selftests/drivers/net/psp.py
> > +++ b/tools/testing/selftests/drivers/net/psp.py
> > @@ -16,11 +16,12 @@ from lib.py import ksft_run, ksft_exit, ksft_pr
> >   from lib.py import ksft_true, ksft_eq, ksft_ne, ksft_gt,
> > ksft_raises
> >   from lib.py import ksft_not_none
> >   from lib.py import ksft_variants, KsftNamedVariant
> > -from lib.py import KsftSkipEx, KsftFailEx
> > +from lib.py import KsftSkipEx, KsftFailEx, KsftXfailEx
> >   from lib.py import NetDrvEpEnv, NetDrvContEnv
> > -from lib.py import Netlink, NlError, PSPFamily, RtnlFamily
> > +from lib.py import Netlink, NlError, NetdevFamily, PSPFamily,
> > RtnlFamily
> >   from lib.py import NetNSEnter
> >   from lib.py import bkg, rand_port, wait_port_listen
> > +from lib.py import bkg, ethtool, rand_port, wait_port_listen,
> > CmdExitFailure
> 
> nit: agent has pointed out that this new line is reimporting bkg, 
> rand_port, and wait_port_listen from the line above it.

Right, thanks for spotting this.
Not sure how this happened, the previous line was supposed to be
replaced by the new one...
Will be fixed.

Cosmin.