Re: [PATCH net-next] selftests/net: packetdrill: make tcp buf limited timing tests benign

Matthieu Baerts
2025-01-17T11:21:30Z

Hi Willem, Jakub,

On 16/01/2025 14:05, Willem de Bruijn wrote:
> Jakub Kicinski wrote:
>> The following tests are failing on debug kernels:
>>
>> tcp_tcp_info_tcp-info-rwnd-limited.pkt
>> tcp_tcp_info_tcp-info-sndbuf-limited.pkt

(...)

> We'll take a look after this change whether we can make these
> more resilient. But likely also allow-list or even xfail for
> everything in dbg.

On MPTCP side, I spent quite a bit of time trying to improve the
situation on debug kernels. Sure it feels good and reassuring to have
spent this time understanding the instabilities. Most issues were due to
spurious retransmissions, because Packetdrill was "too slow" to inject
replies: so more like an issue in the tests. But I don't know if having
these tests running in such slow environments helped to find bugs
directly, e.g. catching unexpected packets. Maybe once? But at what cost?

Still it is good to run them on debug kernels to have extra
verifications on the kernel side. As Ido mentioned last summer, perhaps
we can ignore the test results, but keep logging them, and only look at
the kernel warnings?

So yes, I agree with Willem: if that cannot easily be fixed, ignoring
packetdrill err code for everything in debug sounds like the right
direction.

Cheers,
Matt
--