Re: [PATCH net-next] selftests/net: packetdrill: make tcp buf limited timing tests benign

Willem de Bruijn
2025-01-16T13:05:59Z

Jakub Kicinski wrote:
> The following tests are failing on debug kernels:
>
> tcp_tcp_info_tcp-info-rwnd-limited.pkt
> tcp_tcp_info_tcp-info-sndbuf-limited.pkt
>
> with reports like:
>
> assert 19000 <= tcpi_sndbuf_limited <= 21000, tcpi_sndbuf_limited; \
> AssertionError: 18000
>
> and:
>
> assert 348000 <= tcpi_busy_time <= 360000, tcpi_busy_time
> AssertionError: 362000
>
> Extend commit 912d6f669725 ("selftests/net: packetdrill: report benign
> debug flakes as xfail") to cover them.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>

Reviewed-by: Willem de Bruijn <willemb@google.com>

Thanks.

I see that we'll still have a few flakes on dbg. Perhaps one total
failure a day. From the following.

tcp-close-close-local-close-then-remote-fin-pkt
tcp-ecn-ecn-uses-ect0-pkt
tcp-eor-no-coalesce-retrans-pkt
tcp-slow-start-slow-start-after-win-update-pkt
tcp-sack-sack-route-refresh-ip-tos-pkt
tcp-ts-recent-reset-tsval-pkt
tcp-zerocopy-closed-pkt

We'll take a look after this change whether we can make these
more resilient. But likely also allow-list or even xfail for
everything in dbg.