[PATCH net] selftests: drv-net: tso: make bkg() wait for socat to quit

[PATCH net] selftests: drv-net: tso: make bkg() wait for socat to quit

[Jakub Kicinski]

Commit 846742f7e32f ("selftests: drv-net: add a warning for
bkg + shell + terminate") added a warning for bkg() used
with terminate=True. The tso test was missed as we didn't
have it running anywhere in NIPA. Add exit_wait=True, to avoid:

  # Warning: combining shell and terminate is risky!
  #          SIGTERM may not reach the child on zsh/ksh!

getting printed twice for every variant.

Fixes: 0d0f4174f6c8 ("selftests: drv-net: add a simple TSO test")
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
CC: shuah@kernel.org
CC: willemb@google.com
CC: linux-kselftest@vger.kernel.org
---
 tools/testing/selftests/drivers/net/hw/tso.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/drivers/net/hw/tso.py b/tools/testing/selftests/drivers/net/hw/tso.py
index e1ecb92f79d9..150d6db241a0 100755
--- a/tools/testing/selftests/drivers/net/hw/tso.py
+++ b/tools/testing/selftests/drivers/net/hw/tso.py
@@ -39,7 +39,7 @@ from lib.py import bkg, cmd, defer, ethtool, ip, rand_port, wait_port_listen
     port = rand_port()
     listen_cmd = f"socat -{ipver} -t 2 -u TCP-LISTEN:{port},reuseport /dev/null,ignoreeof"
 
-    with bkg(listen_cmd, host=cfg.remote) as nc:
+    with bkg(listen_cmd, host=cfg.remote, exit_wait=True) as nc:
         wait_port_listen(port, host=cfg.remote)
 
         if ipver == "4":
-- 
2.49.0

Re: [PATCH net] selftests: drv-net: tso: make bkg() wait for socat to quit

[Willem de Bruijn]

Jakub Kicinski wrote:
> Commit 846742f7e32f ("selftests: drv-net: add a warning for
> bkg + shell + terminate") added a warning for bkg() used
> with terminate=True. The tso test was missed as we didn't
> have it running anywhere in NIPA. Add exit_wait=True, to avoid:
> 
>   # Warning: combining shell and terminate is risky!
>   #          SIGTERM may not reach the child on zsh/ksh!
> 
> getting printed twice for every variant.
> 
> Fixes: 0d0f4174f6c8 ("selftests: drv-net: add a simple TSO test")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>

Reviewed-by: Willem de Bruijn <willemb@google.com>

Re: [PATCH net] selftests: drv-net: tso: make bkg() wait for socat to quit

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Tue,  3 Jun 2025 18:20:55 -0700 you wrote:
> Commit 846742f7e32f ("selftests: drv-net: add a warning for
> bkg + shell + terminate") added a warning for bkg() used
> with terminate=True. The tso test was missed as we didn't
> have it running anywhere in NIPA. Add exit_wait=True, to avoid:
> 
>   # Warning: combining shell and terminate is risky!
>   #          SIGTERM may not reach the child on zsh/ksh!
> 
> [...]

Here is the summary with links:
  - [net] selftests: drv-net: tso: make bkg() wait for socat to quit
    https://git.kernel.org/netdev/net/c/e6854be4d80e

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html