From: Jens Axboe <axboe@kernel.dk>
To: Mohit Gupta <mgupta@purestorage.com>,
Caleb Sander Mateos <csander@purestorage.com>,
Ming Lei <ming.lei@redhat.com>, Shuah Khan <shuah@kernel.org>,
Uday Shankar <ushankar@purestorage.com>
Cc: linux-block@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] selftests: ublk: fix behavior when fio is not installed
Date: Sat, 20 Sep 2025 23:18:42 -0600 [thread overview]
Message-ID: <175843192257.42245.2136343963364128168.b4-ty@kernel.dk> (raw)
In-Reply-To: <20250916-ublk_fio-v2-1-04852e6bf42a@purestorage.com>
On Tue, 16 Sep 2025 18:42:52 -0600, Uday Shankar wrote:
> Some ublk selftests have strange behavior when fio is not installed.
> While most tests behave correctly (run if they don't need fio, or skip
> if they need fio), the following tests have different behavior:
>
> - test_null_01, test_null_02, test_generic_01, test_generic_02, and
> test_generic_12 try to run fio without checking if it exists first,
> and fail on any failure of the fio command (including "fio command
> not found"). So these tests fail when they should skip.
> - test_stress_05 runs fio without checking if it exists first, but
> doesn't fail on fio command failure. This test passes, but that pass
> is misleading as the test doesn't do anything useful without fio
> installed. So this test passes when it should skip.
>
> [...]
Applied, thanks!
[1/1] selftests: ublk: fix behavior when fio is not installed
commit: a3835a44107fcbf05f183b5e8b60a8e4605b15ea
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2025-09-21 5:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-17 0:42 [PATCH v2] selftests: ublk: fix behavior when fio is not installed Uday Shankar
2025-09-17 3:40 ` Ming Lei
2025-09-21 5:18 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175843192257.42245.2136343963364128168.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=csander@purestorage.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mgupta@purestorage.com \
--cc=ming.lei@redhat.com \
--cc=shuah@kernel.org \
--cc=ushankar@purestorage.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox