From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f41.google.com (mail-ot1-f41.google.com [209.85.210.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C1041CD15 for ; Thu, 22 Aug 2024 03:03:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724295839; cv=none; b=GcxZcmvYXB9x9cR6ee9EmG36fhgdRBa8Z9SxMqyFTxgMSRhNY2AGbOpy0+v3KJvOYQJDOtTYm3h/WNaWZRaDR6LZ4CSFNHMoN3TF/Q3cwnDJ6/4+G+5igNQr3VOQGlbjOWBfMAPyl1x0HOLiv4tuvjL8si6tsKeEj9VsTKx+vFQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724295839; c=relaxed/simple; bh=2LPG/IslZN06cbBK/YdK57m2GNu2UjglTKoBwajffeU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=REeNnxBbE6pJ71JKPlHAImTCrmI5SXhr+nVf2c1DrKaUpEPo5T22+NnTpqRwR0Q6Gzsf2wMBdKyQJtt9yUzTDD+tqypZzlEUXQqThHVAXUWsuUPwd2WCWLM7BrHk59qUT9Vxa2lHDh38sZSVMc0HpDw9AUVXuEQG0jiub7NiiNU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=PD/izATi; arc=none smtp.client-ip=209.85.210.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="PD/izATi" Received: by mail-ot1-f41.google.com with SMTP id 46e09a7af769-70b3b62025dso255711a34.0 for ; Wed, 21 Aug 2024 20:03:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1724295835; x=1724900635; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=aWQNCvXdOAof/cUwKugkwOsCdNc//NybuZ2r7xMcKFM=; b=PD/izATiCKB1mZBDTaU+N9pyAKEW3u4iOTONpyXyWqulnENAm4A2u3knMEpZ/Cnl1t fuROGJPmA9dlH6/qQ5p11Uq7dBuMYMHh0gMhgdMikihASn1JoXOdH73RZaHToejB3Czk lA8nFS4WH/b0HKNCysB1GYfjDVvzeW0gM1B7Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724295835; x=1724900635; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aWQNCvXdOAof/cUwKugkwOsCdNc//NybuZ2r7xMcKFM=; b=cIyUdDNGMh1uDTXCKbiK9+/DZ7PbD6psyEl9jIO0/jwpXKzqo2S9J9uf4M7svqAxEs olMSoAHChPE2QCQko4+7D93g/oK4RTI2ha6KkjKU/AyGB40/KunPXFCusgXVCkTBvVmi GRJRQnehhvHSljjTwO5t0WVR4Zls5M9GKiOGxi2FWSPilMJsNwE/stiDEm0PonQngAUT HcEmx/apl+q4AvvJjsH9bA865ZASwBUeRLtZS46PCSuxZhJcLF2ZuzP86pkFqBcsTAmA TLLJ5PNVQFRb/r6eEOtRMKFewoxQDjKDV+QLoB95INmwA8DtzrezUdULxWup1TAU4yUV ORNA== X-Forwarded-Encrypted: i=1; AJvYcCUEqZfviudBvS4ySo5LCfVUd9baA2A8kMpyddm6Ly4Z6OVN/po/fSyy8OttRSvugiBjH88mOdxafJzwQ9/CP6k=@vger.kernel.org X-Gm-Message-State: AOJu0YydZhwCHEeaPURzyBmCAyegwBCdKCdRBsYSVujFwW4MP2xA4fp4 GIEDJ7n/YY99wFXqhBTfiJ+V/zhjLleeQKtjIh5mjT10c8UqlcpR1R18PRb3DUw= X-Google-Smtp-Source: AGHT+IEql6VqPfz66pY2JjscwwWqrCsNLSe456gugTBAUQFnfOPHdSwIjtSuBuOQYl2b4QoHSCUuTA== X-Received: by 2002:a05:6830:6e02:b0:70d:edad:8635 with SMTP id 46e09a7af769-70df8873633mr5522595a34.31.1724295835498; Wed, 21 Aug 2024 20:03:55 -0700 (PDT) Received: from [172.20.0.208] ([218.188.70.188]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7143432eda2sm365664b3a.187.2024.08.21.20.03.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Aug 2024 20:03:55 -0700 (PDT) Message-ID: <1ac911c2-9d9c-4408-8697-1e90b3ae3e8d@linuxfoundation.org> Date: Wed, 21 Aug 2024 21:03:51 -0600 Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 1/2] selftests: Rename sigaltstack to generic signal To: Dev Jain , shuah@kernel.org, oleg@redhat.com Cc: mingo@kernel.org, tglx@linutronix.de, mark.rutland@arm.com, ryan.roberts@arm.com, broonie@kernel.org, suzuki.poulose@arm.com, Anshuman.Khandual@arm.com, DeepakKumar.Mishra@arm.com, aneesh.kumar@kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: <20240821061523.2650568-1-dev.jain@arm.com> <20240821061523.2650568-2-dev.jain@arm.com> Content-Language: en-US From: Shuah Khan In-Reply-To: <20240821061523.2650568-2-dev.jain@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 8/21/24 00:15, Dev Jain wrote: > Rename sigaltstack to signal, and rename the existing test to > sigaltstack.c. Can you elaborate on the benefits if renaming the test? Also you have such a good information in the cover-letter for this patch - it would be good to include it in the change log for this one or the new test. The new test itself is good. I don't understand the value of renaming. I can see the problems due to not being able to fix stables if the existing test needs fixing. If there are good reasons for renaming, I am all for it. > > Signed-off-by: Dev Jain > Reviewed-by: Mark Brown > --- > tools/testing/selftests/Makefile | 2 +- > tools/testing/selftests/{sigaltstack => signal}/.gitignore | 2 +- > tools/testing/selftests/{sigaltstack => signal}/Makefile | 2 +- > .../selftests/{sigaltstack => signal}/current_stack_pointer.h | 0 > .../selftests/{sigaltstack/sas.c => signal/sigaltstack.c} | 0 > 5 files changed, 3 insertions(+), 3 deletions(-) > rename tools/testing/selftests/{sigaltstack => signal}/.gitignore (76%) > rename tools/testing/selftests/{sigaltstack => signal}/Makefile (72%) > rename tools/testing/selftests/{sigaltstack => signal}/current_stack_pointer.h (100%) > rename tools/testing/selftests/{sigaltstack/sas.c => signal/sigaltstack.c} (100%) > > diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile > index bc8fe9e8f7f2..edbe30fb3304 100644 > --- a/tools/testing/selftests/Makefile > +++ b/tools/testing/selftests/Makefile > @@ -87,7 +87,7 @@ TARGETS += rtc > TARGETS += rust > TARGETS += seccomp > TARGETS += sgx > -TARGETS += sigaltstack > +TARGETS += signal > TARGETS += size > TARGETS += sparc64 > TARGETS += splice > diff --git a/tools/testing/selftests/sigaltstack/.gitignore b/tools/testing/selftests/signal/.gitignore > similarity index 76% > rename from tools/testing/selftests/sigaltstack/.gitignore > rename to tools/testing/selftests/signal/.gitignore > index 50a19a8888ce..98a7bbc4f325 100644 > --- a/tools/testing/selftests/sigaltstack/.gitignore > +++ b/tools/testing/selftests/signal/.gitignore > @@ -1,2 +1,2 @@ > # SPDX-License-Identifier: GPL-2.0-only > -sas > +sigaltstack > diff --git a/tools/testing/selftests/sigaltstack/Makefile b/tools/testing/selftests/signal/Makefile > similarity index 72% > rename from tools/testing/selftests/sigaltstack/Makefile > rename to tools/testing/selftests/signal/Makefile > index 3e96d5d47036..dd6be992fd81 100644 > --- a/tools/testing/selftests/sigaltstack/Makefile > +++ b/tools/testing/selftests/signal/Makefile > @@ -1,6 +1,6 @@ > # SPDX-License-Identifier: GPL-2.0-only > CFLAGS = -Wall > -TEST_GEN_PROGS = sas > +TEST_GEN_PROGS = sigaltstack > > include ../lib.mk > > diff --git a/tools/testing/selftests/sigaltstack/current_stack_pointer.h b/tools/testing/selftests/signal/current_stack_pointer.h > similarity index 100% > rename from tools/testing/selftests/sigaltstack/current_stack_pointer.h > rename to tools/testing/selftests/signal/current_stack_pointer.h > diff --git a/tools/testing/selftests/sigaltstack/sas.c b/tools/testing/selftests/signal/sigaltstack.c > similarity index 100% > rename from tools/testing/selftests/sigaltstack/sas.c > rename to tools/testing/selftests/signal/sigaltstack.c thanks, -- Shuah