Linux Kernel Selftest development
 help / color / mirror / Atom feed
From: Shuah Khan <skhan@linuxfoundation.org>
To: Christian Brauner <christian.brauner@ubuntu.com>,
	Tobias Klauser <tklauser@distanz.ch>
Cc: Shuah Khan <shuah@kernel.org>,
	linux-kselftest@vger.kernel.org,
	Giuseppe Scrivano <gscrivan@redhat.com>,
	Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] selftests/core: fix close_range_test build after XFAIL removal
Date: Mon, 8 Feb 2021 17:24:33 -0700	[thread overview]
Message-ID: <1ae15d95-51e5-cbd5-537f-833d4dc9bf97@linuxfoundation.org> (raw)
In-Reply-To: <20201218122555.rlazqtui5pn5wm3u@wittgenstein>

On 12/18/20 5:25 AM, Christian Brauner wrote:
> On Fri, Dec 18, 2020 at 12:24:28PM +0100, Tobias Klauser wrote:
>> XFAIL was removed in commit 9847d24af95c ("selftests/harness: Refactor
>> XFAIL into SKIP") and its use in close_range_test was already replaced
>> by commit 1d44d0dd61b6 ("selftests: core: use SKIP instead of XFAIL in
>> close_range_test.c"). However, commit 23afeaeff3d9 ("selftests: core:
>> add tests for CLOSE_RANGE_CLOEXEC") introduced usage of XFAIL in
>> TEST(close_range_cloexec). Use SKIP there as well.
>>
>> Cc: Giuseppe Scrivano <gscrivan@redhat.com>
>> Fixes: 23afeaeff3d9 ("selftests: core: add tests for CLOSE_RANGE_CLOEXEC")
>> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
>> ---
> 
> Thanks for this! I already have a fix for this in my tree but I'm
> dropping it and taking yours instead.
> 
> Acked-by: Christian Brauner <christian.brauner@ubuntu.com>
> 
> Shuah, I'll be taking this through my tree since I'm adding selftests
> for a vfs regression fix that I'll be sending before Sunday.
> 
> Christian
> 

Thank you Christian

thanks,
-- Shuah

      reply	other threads:[~2021-02-09  0:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-18 11:24 [PATCH] selftests/core: fix close_range_test build after XFAIL removal Tobias Klauser
2020-12-18 12:25 ` Christian Brauner
2021-02-09  0:24   ` Shuah Khan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1ae15d95-51e5-cbd5-537f-833d4dc9bf97@linuxfoundation.org \
    --to=skhan@linuxfoundation.org \
    --cc=christian.brauner@ubuntu.com \
    --cc=gscrivan@redhat.com \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=shuah@kernel.org \
    --cc=tklauser@distanz.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox