From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2B44C00528 for ; Wed, 2 Aug 2023 08:04:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231264AbjHBIEV (ORCPT ); Wed, 2 Aug 2023 04:04:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59010 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232069AbjHBIES (ORCPT ); Wed, 2 Aug 2023 04:04:18 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 349BB1BC7 for ; Wed, 2 Aug 2023 01:03:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690963402; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Oo+8dg/DBj2V+G5oZvUMnojMP7aeWCXmA1VlhFSPE34=; b=MLIkqV0jM9kST61nx5Nc5Ci5Pu3ZY8QN+swbLtcZ0XVT4SxprYUbUQFETuJie32I7PIqEw B8/TXvd38n7DyfOwE5q+kuHaGy1frzE03BbDKBHaCQxtjCySIUQfasayrt2kTn8CJ2lLvH 5GQvs6bOQZfQ26j0E+9H/zbU+UMRwtM= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-571-XEhUn3bQOjmAWLZp70QSLg-1; Wed, 02 Aug 2023 04:03:20 -0400 X-MC-Unique: XEhUn3bQOjmAWLZp70QSLg-1 Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-76ca3baaec8so76571985a.1 for ; Wed, 02 Aug 2023 01:03:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690963400; x=1691568200; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Oo+8dg/DBj2V+G5oZvUMnojMP7aeWCXmA1VlhFSPE34=; b=a9N+7pu7QHHUi1VyXuxoR/InUKUtXBauxJCWOOLegUIl83C/+baZIoamL0xubmydNi V/6IjIlbq07GYNyCd3Rom5bOy4FWmC7t7vxnX4ccVbHH6Lxi5Wp0vK7/q3HW60GA3Yhq UoF/rmQxkqQr20OtEEqaGCa2j3N0kAZqm3B5OmZDC+btspYPgTohcc7aSTj4vr72bd5m wQB/ITnXU1y8xnpyNAKbhtATmZiKMFUWDa9QBK9W/zXufp5sEfSF8wx0QA+pO3ph56uF OPNLIidVNaE5euvFm70L+BgJheQ9WkR+MHYgf12S8DlGIQIuWMv8t/Hc6ClUE4lPUUit sxkA== X-Gm-Message-State: ABy/qLZuznT/HfxlaAJ6sGApFnuagtd5fV9lvXaN5JtOI5zJz9/TJS/q CrzXCrGh6TXACbJZU1r3g9MD8vWEvb6z6cB9B9RfCq8aZ6+BgwjrS+Sa4kYgeUleSXjBlq4EWiZ Dg9xyNe1W21+G9jVtTVyUneouC4zK X-Received: by 2002:a05:620a:31aa:b0:767:7a4c:1b9e with SMTP id bi42-20020a05620a31aa00b007677a4c1b9emr15272968qkb.7.1690963399776; Wed, 02 Aug 2023 01:03:19 -0700 (PDT) X-Google-Smtp-Source: APBJJlFnNAWWhSXb/HktBSfXGFmabV1fvsy307saOx2MgChsfs7xTXLkVxm9csctRpjZ4apFAXP/zg== X-Received: by 2002:a05:620a:31aa:b0:767:7a4c:1b9e with SMTP id bi42-20020a05620a31aa00b007677a4c1b9emr15272941qkb.7.1690963399461; Wed, 02 Aug 2023 01:03:19 -0700 (PDT) Received: from gerbillo.redhat.com (146-241-233-7.dyn.eolo.it. [146.241.233.7]) by smtp.gmail.com with ESMTPSA id p12-20020a05620a132c00b0076c9cc1e107sm3299044qkj.54.2023.08.02.01.03.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Aug 2023 01:03:18 -0700 (PDT) Message-ID: <1b51c79c59cb3ec4be95e993be9be2e5d9441670.camel@redhat.com> Subject: Re: [RFC bpf-next v7 0/6] bpf: Force to MPTCP From: Paolo Abeni To: Alexei Starovoitov , Geliang Tang Cc: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Florent Revest , Brendan Jackman , Matthieu Baerts , Mat Martineau , "David S. Miller" , Eric Dumazet , Jakub Kicinski , John Johansen , Paul Moore , James Morris , "Serge E. Hallyn" , Stephen Smalley , Eric Paris , Mykola Lysenko , Shuah Khan , bpf@vger.kernel.org, netdev@vger.kernel.org, mptcp@lists.linux.dev, apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org, selinux@vger.kernel.org, linux-kselftest@vger.kernel.org Date: Wed, 02 Aug 2023 10:03:12 +0200 In-Reply-To: <20230801004323.l2npfegkq3srzff3@MacBook-Pro-8.local> References: <20230801004323.l2npfegkq3srzff3@MacBook-Pro-8.local> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Mon, 2023-07-31 at 17:43 -0700, Alexei Starovoitov wrote: > I still think it's a hack, but its blast radius is nicely contained. > And since I cannot propose any better I'm ok with it. >=20 > Patches 1-2 can be squashed into one. > Just like patches 3-6 as a single patch for selftests. >=20 > But before proceeding I'd like an explicit ack from netdev maintainers. Just to state the obvious, I carry my personal bias on this topic due to my background ;) My perspective is quite similar to Alexei's one: the solution is not extremely elegant, but is very self-contained; it looks viable to me. WRT the specific code, I think the additional checks on the 'protocol' value after the 'update_socket_protocol()' call should be dropped: the user space can already provide an arbitrary value there and the later code deal with that. Cheers, Paolo