Re: [PATCH v3 6/7] platform/x86/amd/pmf: Introduce AMD PMF testing tool for driver metrics and features

[Shyam Sundar S K <Shyam-sundar.S-k@amd.com>]

On 3/26/2026 15:50, Ilpo Järvinen wrote:
> On Wed, 25 Mar 2026, Mario Limonciello wrote:
>> On 3/25/26 08:54, Ilpo Järvinen wrote:
>>> + Selftest people.
>>>
>>> On Sun, 1 Mar 2026, Shyam Sundar S K wrote:
>>>
>>>> This tool leverages amd-pmf ioctls exposed via the util layer, allowing
>>>> validation of its newly integrated util layer and /dev/amdpmf_interface.
>>>> It includes a user-space test application, test_pmf, designed to interact
>>>> with the PMF driver and retrieve relevant metrics for the testing and
>>>> analysis.
>>>>
>>>> It provides definitions for test metrics, feature IDs, and device states,
>>>> and includes tests for various AMD PMF metrics such as power source, skin
>>>> temperature, battery state, and custom BIOS inputs/outputs. It also
>>>> enables the testing of PMF metrics data and feature support reporting.
>>>>
>>>> Co-developed-by: Sanket Goswami <Sanket.Goswami@amd.com>
>>>> Signed-off-by: Sanket Goswami <Sanket.Goswami@amd.com>
>>>> Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
>>>> ---
>>>>   tools/testing/selftests/Makefile              |   1 +
>>>>   .../drivers/platform/x86/amd/pmf/Makefile     |   8 +
>>>>   .../drivers/platform/x86/amd/pmf/test_pmf.c   | 243 ++++++++++++++++++
>>>>   3 files changed, 252 insertions(+)
>>>>   create mode 100644
>>>> tools/testing/selftests/drivers/platform/x86/amd/pmf/Makefile
>>>>   create mode 100644
>>>> tools/testing/selftests/drivers/platform/x86/amd/pmf/test_pmf.c
>>>
>>> Please Cc also selftest people in the next version submission! Maube you
>>> should also check why your patch sending process did not capture those
>>> receipient for you.
>>>
>>> To me it looks this "tool" doesn't really perform a selftest the way I've
>>> understood "selftests" work. That is, it doesn't have notion of Pass/Fail
>>> at all AFAICT. I'm not sure if there are other selftests like this but
>>> hopefully the selftest people know.
>>
>> For a similar "tool" I have it outside of selftests:
>>
>> linux/tools/crypto/ccp
>>
>> Ilpo,
>>
>> Maybe we want a directory structure like this?
>>
>> tools/platform/x86/amd
> 
> At least to me it looks better than placing a non-selftest tool under 
> selftests/.
> 

Even I think this is a good choice. Thanks! I will make this change in
the next version.


Thanks,
Shyam