From: Yunsheng Lin <yunshenglin0825@gmail.com>
To: Mina Almasry <almasrymina@google.com>,
Yunsheng Lin <linyunsheng@huawei.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
Jesper Dangaard Brouer <hawk@kernel.org>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Shuah Khan <shuah@kernel.org>
Subject: Re: [PATCH net-next v1 2/7] net: page_pool: create page_pool_alloc_netmem
Date: Sun, 3 Nov 2024 22:35:00 +0800 [thread overview]
Message-ID: <1d8c55c7-1406-4af6-9dce-0b296cd40fc9@gmail.com> (raw)
In-Reply-To: <CAHS8izMgF8nx87D9pWPmq1pfDm1v8x5Z6gc_eMHcYo8zKX-Lrw@mail.gmail.com>
On 11/1/2024 9:10 PM, Mina Almasry wrote:
...
>>
>> Isn't it a little odd that old and new are not following the same
>> pattern?
>
> Hi Yunsheng,
>
> The intention is that page_pool_alloc_pages is mirrored by
> page_pool_alloc_netmems.
>
> And page_pool_alloc is mirrored by page_pool_alloc_netmem.
>
>>From your description, the behavior is the same for each function and
> its mirror. What is the gap in the pattern that you see?
I was mostly referring to the API naming pattern.
Isn't it better if page_pool_alloc is mirrored by netmem_pool_alloc and
netmem_pool_alloc_netmems is mirrored by page_pool_alloc_pages() from
API naming prespective?
And maybe page_pool_alloc_frag can be mirrored by netmem_pool_alloc_frag
in the future?
Also, it would be good to update Documentation/networking/page_pool.rst
for those new netmem APIs, or create a new doc file for them.
>
next prev parent reply other threads:[~2024-11-03 14:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-29 20:45 [PATCH net-next v1 0/7] devmem TCP fixes Mina Almasry
2024-10-29 20:45 ` [PATCH net-next v1 1/7] net: page_pool: rename page_pool_alloc_netmem to *_netmems Mina Almasry
2024-10-29 20:45 ` [PATCH net-next v1 2/7] net: page_pool: create page_pool_alloc_netmem Mina Almasry
2024-11-01 11:14 ` Yunsheng Lin
2024-11-01 13:10 ` Mina Almasry
2024-11-03 14:35 ` Yunsheng Lin [this message]
2024-11-07 21:08 ` Mina Almasry
2024-10-29 20:45 ` [PATCH net-next v1 3/7] page_pool: Set `dma_sync` to false for devmem memory provider Mina Almasry
2024-10-29 20:45 ` [PATCH net-next v1 4/7] page_pool: disable sync for cpu for dmabuf " Mina Almasry
2024-10-29 20:45 ` [PATCH net-next v1 5/7] netmem: add netmem_prefetch Mina Almasry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d8c55c7-1406-4af6-9dce-0b296cd40fc9@gmail.com \
--to=yunshenglin0825@gmail.com \
--cc=almasrymina@google.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=horms@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linyunsheng@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox