From: Matthieu Baerts <matttbe@kernel.org>
To: Hangbin Liu <liuhangbin@gmail.com>
Cc: Jan Stancek <jstancek@redhat.com>,
pshelar@ovn.org, kuba@kernel.org, davem@davemloft.net,
edumazet@google.com, pabeni@redhat.com,
linux-kselftest@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net] selftests: net/{lib,openvswitch}: extend CFLAGS to keep options from environment
Date: Mon, 27 Jan 2025 15:50:30 +0100 [thread overview]
Message-ID: <1e9ec1e3-7a74-4566-ba5b-e937e33336e2@kernel.org> (raw)
In-Reply-To: <Z5WX7rUMINgA3KVJ@fedora>
Hi Hangbin,
On 26/01/2025 03:03, Hangbin Liu wrote:
> On Thu, Jan 23, 2025 at 01:51:27PM +0100, Matthieu Baerts wrote:
>>> openvswitch/Makefile CFLAGS currently do not appear to be used, but
>>> fix it anyway for the case when new tests are introduced in future.
>>>
>>> Fixes: 1d0dc857b5d8 ("selftests: drv-net: add checksum tests")
>>
>> Note that this commit is only for the Makefile in 'lib', not in
>> 'openvswitch', but I guess there is no need to backport that all along.
>> Maybe the two modifications should be split, but I guess that's fine here.
>
> Maybe we can also add
>
> Fixes: 25f16c873fb1 ("selftests: add openvswitch selftest suite")
I don't think it is needed. If it is, probably best to split the patch
in two then.
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
next prev parent reply other threads:[~2025-01-27 14:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-23 12:38 [PATCH net] selftests: net/{lib,openvswitch}: extend CFLAGS to keep options from environment Jan Stancek
2025-01-23 12:51 ` Matthieu Baerts
2025-01-26 2:03 ` Hangbin Liu
2025-01-27 14:50 ` Matthieu Baerts [this message]
2025-01-27 23:04 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e9ec1e3-7a74-4566-ba5b-e937e33336e2@kernel.org \
--to=matttbe@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jstancek@redhat.com \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pshelar@ovn.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox