From: davem at davemloft.net (David Miller)
Subject: [PATCH] selftest: net: reuseport_bpf_numa: don't fail if no numa support
Date: Wed, 07 Mar 2018 13:25:00 -0500 (EST) [thread overview]
Message-ID: <20180307.132500.40232199631094354.davem@davemloft.net> (raw)
In-Reply-To: <20180306151004.31336-1-anders.roxell@linaro.org>
From: Anders Roxell <anders.roxell at linaro.org>
Date: Tue, 6 Mar 2018 16:10:04 +0100
> The reuseport_bpf_numa test case fails there's no numa support. The
> test shouldn't fail if there's no support it should be skipped with a
> pass.
>
> Fixes: 3c2c3c16aaf6 ("reuseport, bpf: add test case for bpf_get_numa_node_id")
> Signed-off-by: Anders Roxell <anders.roxell at linaro.org>
I don't know about this.
The test did not pass. So it should not be "skipped with a pass".
We were unable to run it at all, which means we don't know if it
would pass or fail. This means there is a third state besides
pass or fail which we must acknowledge and implement.
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: davem@davemloft.net (David Miller)
Subject: [PATCH] selftest: net: reuseport_bpf_numa: don't fail if no numa support
Date: Wed, 07 Mar 2018 13:25:00 -0500 (EST) [thread overview]
Message-ID: <20180307.132500.40232199631094354.davem@davemloft.net> (raw)
Message-ID: <20180307182500.6dMnoF_FFlr0PK5fbvYNdTWFUzoYbrPwb_gria6JHM0@z> (raw)
In-Reply-To: <20180306151004.31336-1-anders.roxell@linaro.org>
From: Anders Roxell <anders.roxell@linaro.org>
Date: Tue, 6 Mar 2018 16:10:04 +0100
> The reuseport_bpf_numa test case fails there's no numa support. The
> test shouldn't fail if there's no support it should be skipped with a
> pass.
>
> Fixes: 3c2c3c16aaf6 ("reuseport, bpf: add test case for bpf_get_numa_node_id")
> Signed-off-by: Anders Roxell <anders.roxell at linaro.org>
I don't know about this.
The test did not pass. So it should not be "skipped with a pass".
We were unable to run it at all, which means we don't know if it
would pass or fail. This means there is a third state besides
pass or fail which we must acknowledge and implement.
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-03-07 18:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-06 15:10 [PATCH] selftest: net: reuseport_bpf_numa: don't fail if no numa support anders.roxell
2018-03-06 15:10 ` Anders Roxell
2018-03-07 18:25 ` davem [this message]
2018-03-07 18:25 ` David Miller
2018-03-07 19:51 ` shuah
2018-03-07 19:51 ` Shuah Khan
2018-03-07 19:59 ` davem
2018-03-07 19:59 ` David Miller
2018-05-18 22:27 ` [PATCH v2] selftests: " anders.roxell
2018-05-18 22:27 ` Anders Roxell
2018-05-23 10:29 ` daniel
2018-05-23 10:29 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180307.132500.40232199631094354.davem@davemloft.net \
--to=linux-kselftest@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).