From mboxrd@z Thu Jan 1 00:00:00 1970 From: rostedt at goodmis.org (Steven Rostedt) Date: Fri, 10 May 2019 10:54:00 -0400 Subject: [PATCH 2/4] x86/kprobes: Fix frame pointer annotations In-Reply-To: <20190510121720.GT2589@hirez.programming.kicks-ass.net> References: <20190508115416.nblx7c2kocidpytm@treble> <20190508120416.GL2589@hirez.programming.kicks-ass.net> <20190508124248.u5ukpbhnh4wpiccq@treble> <20190508153907.GM2589@hirez.programming.kicks-ass.net> <20190508184848.qerg3flv3ej3xsev@treble> <20190509102030.dfa62e058f09d0d8cbdd6053@kernel.org> <20190509081431.GO2589@hirez.programming.kicks-ass.net> <81170F0B-A2BB-4CD6-A1B5-5E7E0DDBC282@amacapital.net> <20190509174316.pzuakeu657g3fnlm@home.goodmis.org> <20190510122103.5a7bc5416b7af96b27d4fab4@kernel.org> <20190510121720.GT2589@hirez.programming.kicks-ass.net> Message-ID: <20190510105400.0d267e9f@gandalf.local.home> On Fri, 10 May 2019 14:17:20 +0200 Peter Zijlstra wrote: > But both ftrace and retprobes are at C function call boundaries. > Preserving flags doesn't make sense. I agree, but I did it just because of my OCD and being complete in "emulating an int3" for ftrace_regs_caller ;-) Yeah, we can remove the popfl from the ftrace trampoline. -- Steve From mboxrd@z Thu Jan 1 00:00:00 1970 From: rostedt@goodmis.org (Steven Rostedt) Date: Fri, 10 May 2019 10:54:00 -0400 Subject: [PATCH 2/4] x86/kprobes: Fix frame pointer annotations In-Reply-To: <20190510121720.GT2589@hirez.programming.kicks-ass.net> References: <20190508115416.nblx7c2kocidpytm@treble> <20190508120416.GL2589@hirez.programming.kicks-ass.net> <20190508124248.u5ukpbhnh4wpiccq@treble> <20190508153907.GM2589@hirez.programming.kicks-ass.net> <20190508184848.qerg3flv3ej3xsev@treble> <20190509102030.dfa62e058f09d0d8cbdd6053@kernel.org> <20190509081431.GO2589@hirez.programming.kicks-ass.net> <81170F0B-A2BB-4CD6-A1B5-5E7E0DDBC282@amacapital.net> <20190509174316.pzuakeu657g3fnlm@home.goodmis.org> <20190510122103.5a7bc5416b7af96b27d4fab4@kernel.org> <20190510121720.GT2589@hirez.programming.kicks-ass.net> Message-ID: <20190510105400.0d267e9f@gandalf.local.home> Content-Type: text/plain; charset="UTF-8" Message-ID: <20190510145400.s1yN3qbzzfE3tgJ4Vm39_Ajcl_QQjdwt-EKuLFk3924@z> On Fri, 10 May 2019 14:17:20 +0200 Peter Zijlstra wrote: > But both ftrace and retprobes are at C function call boundaries. > Preserving flags doesn't make sense. I agree, but I did it just because of my OCD and being complete in "emulating an int3" for ftrace_regs_caller ;-) Yeah, we can remove the popfl from the ftrace trampoline. -- Steve