From mboxrd@z Thu Jan 1 00:00:00 1970 From: keescook at chromium.org (Kees Cook) Date: Fri, 7 Jun 2019 20:49:05 -0700 Subject: [PATCH v16 04/16] mm: untag user pointers in do_pages_move In-Reply-To: References: Message-ID: <201906072049.C71D545@keescook> On Mon, Jun 03, 2019 at 06:55:06PM +0200, Andrey Konovalov wrote: > This patch is a part of a series that extends arm64 kernel ABI to allow to > pass tagged user pointers (with the top byte set to something else other > than 0x00) as syscall arguments. > > do_pages_move() is used in the implementation of the move_pages syscall. > > Untag user pointers in this function. > > Reviewed-by: Catalin Marinas > Signed-off-by: Andrey Konovalov Reviewed-by: Kees Cook -Kees > --- > mm/migrate.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/mm/migrate.c b/mm/migrate.c > index f2ecc2855a12..3930bb6fa656 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -1617,6 +1617,7 @@ static int do_pages_move(struct mm_struct *mm, nodemask_t task_nodes, > if (get_user(node, nodes + i)) > goto out_flush; > addr = (unsigned long)p; > + addr = untagged_addr(addr); > > err = -ENODEV; > if (node < 0 || node >= MAX_NUMNODES) > -- > 2.22.0.rc1.311.g5d7573a151-goog > -- Kees Cook From mboxrd@z Thu Jan 1 00:00:00 1970 From: keescook@chromium.org (Kees Cook) Date: Fri, 7 Jun 2019 20:49:05 -0700 Subject: [PATCH v16 04/16] mm: untag user pointers in do_pages_move In-Reply-To: References: Message-ID: <201906072049.C71D545@keescook> Content-Type: text/plain; charset="UTF-8" Message-ID: <20190608034905.QILQO4TlSP1_gAsZdoO7v0tpQu88azHWwZ6GYbkLhtk@z> On Mon, Jun 03, 2019@06:55:06PM +0200, Andrey Konovalov wrote: > This patch is a part of a series that extends arm64 kernel ABI to allow to > pass tagged user pointers (with the top byte set to something else other > than 0x00) as syscall arguments. > > do_pages_move() is used in the implementation of the move_pages syscall. > > Untag user pointers in this function. > > Reviewed-by: Catalin Marinas > Signed-off-by: Andrey Konovalov Reviewed-by: Kees Cook -Kees > --- > mm/migrate.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/mm/migrate.c b/mm/migrate.c > index f2ecc2855a12..3930bb6fa656 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -1617,6 +1617,7 @@ static int do_pages_move(struct mm_struct *mm, nodemask_t task_nodes, > if (get_user(node, nodes + i)) > goto out_flush; > addr = (unsigned long)p; > + addr = untagged_addr(addr); > > err = -ENODEV; > if (node < 0 || node >= MAX_NUMNODES) > -- > 2.22.0.rc1.311.g5d7573a151-goog > -- Kees Cook From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 695E0C28CC5 for ; Sat, 8 Jun 2019 03:49:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3EEA42146E for ; Sat, 8 Jun 2019 03:49:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="H67pCnfy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730714AbfFHDtI (ORCPT ); Fri, 7 Jun 2019 23:49:08 -0400 Received: from mail-pf1-f193.google.com ([209.85.210.193]:40636 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730697AbfFHDtH (ORCPT ); Fri, 7 Jun 2019 23:49:07 -0400 Received: by mail-pf1-f193.google.com with SMTP id u17so2221303pfn.7 for ; Fri, 07 Jun 2019 20:49:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=5iFtOAxSpyEwrNGKsnJSAuPHnmB6sZsxY7o3VcURDbs=; b=H67pCnfy+inYwtx7CHiN5h4f1U/pgcnleLkOrUnW4+QdjbqfAr9cQdSkm3W08ImQFl MKpSL+Xxt/SE/t0ZUnbh42ewav3Rgd/mWolnnSDbYBR+Ld/cLmR9BtGJ7sEbWVa+oHPR 1hTMHtgCUOMHLDYeeHgvIO8Lm0UyCIchcEask= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=5iFtOAxSpyEwrNGKsnJSAuPHnmB6sZsxY7o3VcURDbs=; b=l9CW4rjv6LfNPwsicmgK71YWoEFvTOIXQ+wlPGWHMeviNLi48n3xB2majv/M1bLrsb tNDZmQE5jgXLN3DGB4wYj0GWGN6l+3zEZm6Rril20/3KSuuKaFfthGZ4RH0JB9QrE4Rc yHS07Zt8IldthkSKnHZTwPrHzubPokR2sb1KTGnOtF8MmOfRzFsWsPPjldCvSvWX/YZj R5GvzgDE/sANQcWqGuQSAdXnPc2oUK1j5YkliJRKCrKYyyjHcYkJVdzyN6RY+r3VEtv9 Z6WoRYcPEm1pH1RJ58R0rXGMTY4hXq9hsWde3YrFTx74BNt+y097u4m7IFKI8jGyaUZC 2H/A== X-Gm-Message-State: APjAAAUQFgKaEViXus+PFnD/Boj8FQkoIqPoLg6NlUDuzD6kF1hdwDue BDCrDnCyjddAWIJZ0QIf9BccPg== X-Google-Smtp-Source: APXvYqyjpXWbpUp/M/TNwB1KLrsvdqCimHBytjvPEw0jUB6ar1HA2nI5YlI2gocy+KHTqRtIofNEIA== X-Received: by 2002:a63:5247:: with SMTP id s7mr5637363pgl.29.1559965746908; Fri, 07 Jun 2019 20:49:06 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id y12sm3218417pgi.10.2019.06.07.20.49.05 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 07 Jun 2019 20:49:06 -0700 (PDT) Date: Fri, 7 Jun 2019 20:49:05 -0700 From: Kees Cook To: Andrey Konovalov Cc: linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-rdma@vger.kernel.org, linux-media@vger.kernel.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, Catalin Marinas , Vincenzo Frascino , Will Deacon , Mark Rutland , Andrew Morton , Greg Kroah-Hartman , Yishai Hadas , Felix Kuehling , Alexander Deucher , Christian Koenig , Mauro Carvalho Chehab , Jens Wiklander , Alex Williamson , Leon Romanovsky , Luc Van Oostenryck , Dave Martin , Khalid Aziz , enh , Jason Gunthorpe , Christoph Hellwig , Dmitry Vyukov , Kostya Serebryany , Evgeniy Stepanov , Lee Smith , Ramana Radhakrishnan , Jacob Bramley , Ruben Ayrapetyan , Robin Murphy , Kevin Brodsky , Szabolcs Nagy Subject: Re: [PATCH v16 04/16] mm: untag user pointers in do_pages_move Message-ID: <201906072049.C71D545@keescook> References: MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org Message-ID: <20190608034905.4pYQ4Yg0xrZr39s-HqytUbaiVFEm3Bpz4KIJ00byXTE@z> On Mon, Jun 03, 2019 at 06:55:06PM +0200, Andrey Konovalov wrote: > This patch is a part of a series that extends arm64 kernel ABI to allow to > pass tagged user pointers (with the top byte set to something else other > than 0x00) as syscall arguments. > > do_pages_move() is used in the implementation of the move_pages syscall. > > Untag user pointers in this function. > > Reviewed-by: Catalin Marinas > Signed-off-by: Andrey Konovalov Reviewed-by: Kees Cook -Kees > --- > mm/migrate.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/mm/migrate.c b/mm/migrate.c > index f2ecc2855a12..3930bb6fa656 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -1617,6 +1617,7 @@ static int do_pages_move(struct mm_struct *mm, nodemask_t task_nodes, > if (get_user(node, nodes + i)) > goto out_flush; > addr = (unsigned long)p; > + addr = untagged_addr(addr); > > err = -ENODEV; > if (node < 0 || node >= MAX_NUMNODES) > -- > 2.22.0.rc1.311.g5d7573a151-goog > -- Kees Cook